490702 - Remove obsolete leftovers from removed clear passwords and offline data options in clear recent history dialog

Status: RESOLVED FIXED

(Firefox :: Private Browsing, defect)

Description

[Dave Garrett]

The clear passwords and clear offline data options are no longer in the new clear recent history dialog from bug 480169. (see also bug 472226 & bug 463343) There's still some vestigial bits leftover from them:

sanitize.js:  passwords and offlineApps functions
sanitize.xul:  <preferences> for passwords and offlineApps
defaults/pref/firefox.js:  default prefs for above
sanitize.dtd:  strings and access keys (assuming these aren't going to be reused)

Comment 1

[Dave Garrett]

Scratch prefs and strings; they're reused in the preferences in the clear on exit dialog.

Comment 2

[Dave Garrett]

And sanitize.js is also used for the on exit sanitize. I think all that's really leftover are the <preference> lines in the clear recent history's sanitize.xul. (unless I'm missing something)

Comment 3

[(no longer active)]

Attachment: Patch (v1)

Comment 4

[Dão Gottwald [:dao]]

I may be missing something in the involved code. Doesn't the sanitizer still clear passwords and offlineApp data if privacy.cpd.passwords / privacy.cpd.offlineApps are true, even if initiated from sanitizeDialog.js?

Comment 5

[(no longer active)]

Yes, but the <preference> elements in browser/base/content/sanitize.xul have nothing to do with that.  That logic is embedded in browser/base/content/sanitize.js and applies to all of its consumers.

Comment 6

[Dão Gottwald [:dao]]

Is there a bug for that?

Comment 7

[(no longer active)]

Hmm, a bug for what?  The behavior I explained in comment 5 is the current and expected one.

Comment 8

[Dão Gottwald [:dao]]

The Clear Recent History dialog potentially removes data that it doesn't offer a checkbox for, and that's expected behavior?

Comment 9

[Drew Willcoxon :adw]

(In reply to comment #8)
> The Clear Recent History dialog potentially removes data that it doesn't offer
> a checkbox for, and that's expected behavior?

Bug 497656.

Comment 10

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/78fa6be2aac1