490713 - Convert newlines to empty only for URLs; convert to spaces for other

Status: RESOLVED INACTIVE

(Firefox :: Address Bar, defect)

Description

[Ed Lee :Mardak]

We switched to newline -> empty to address issues of http://line-wrapped
urls/

I've been running into issues where I copy/paste addresses with keywords like "map" and the street gets concated with the city.

We could be smarter and only convert newlines to empty if it's uri-like.

Comment 1

[Marco Bonardo [:mak]]

could you please add a reference to the bug that changed the behavior?

Comment 2

[Ed Lee :Mardak]

I'm not really sure anymore.. I thought this was a recent change because I noticed something strange happening, so I changed my prefs not too long ago. But the only thing I can find is bug 406062 which actually makes newlines turn into spaces (value 2): http://kb.mozillazine.org/Editor.singleLine.pasteNewlines

And faaborg mentioned that we remove newlines to handle split urls.. hrmm...

Comment 3

[(not currently active) Ted Mielczarek]

I changed the behavior of the URL bar in bug 23485. The meat of the behavior is in bug 253481, and happens way down in the editor code.
http://mxr.mozilla.org/mozilla-central/source/editor/libeditor/text/nsTextEditRules.cpp#571

Comment 4

[:Hb]

Citing Matthieu from bug 23485 comment 130:

Pasting
http://goodsite.com
.badsite.com/

Brings me to http://goodsite.com.badsite.com/ while displaying
http://goodsite.com ...

Comment 5

[(not currently active) Ted Mielczarek]

Hb: that is an ancient comment that predates my change. You'll find that if you actually try that on a current Firefox (3.0.x or later), that the URLbar both loads and displays "http://goodsite.com.badsite.com/".

Comment 6

[gadjo]

For data urls it should convert new line to space:

data:text/html,<input required autofocus required autofocus required autofocus
required autofocus required autofocus required autofocus>

After copying this to location bar words "required" and "autofocus" are joined, should be separate
It works ok when copying from textarea

Comment 8

[BMO Automation]

Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.