Closed Bug 490957 Opened 11 years ago Closed 11 years ago

[FIX]Nix nsWebShell

Categories

(Core :: DOM: Navigation, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: bzbarsky, Assigned: bzbarsky)

Details

(Keywords: dev-doc-complete)

Attachments

(1 file)

We should just merge this into nsDocShell.
Attached patch Like soSplinter Review
I got a bit carried away with some of the comment/renaming changes...

If you don't object, as a followup I'd like to move all files in webshell/public into docshell/base and get rid of "webshell" from REQUIRES everywhere.
Attachment #375291 - Flags: superreview?(benjamin)
Attachment #375291 - Flags: review?(benjamin)
Comment on attachment 375291 [details] [diff] [review]
Like so

Don't worry about REQUIRES: once bug 488175 lands REQUIRES will be obsolete anyway.
Attachment #375291 - Flags: superreview?(benjamin)
Attachment #375291 - Flags: superreview+
Attachment #375291 - Flags: review?(benjamin)
Attachment #375291 - Flags: review+
Pushed http://hg.mozilla.org/mozilla-central/rev/53eebf02eac7
Status: NEW → RESOLVED
Closed: 11 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
There's no documentation about this change anywhere that I could find.  I had to compare the Firefox 3.5 and 3.6 code to figure out this is the reason why one of my add-ons isn't working in Firefox 3.6.  

At least the following pages need changing:

https://developer.mozilla.org/en/nsIWebNavigation
https://developer.mozilla.org/en/Firefox_3.6_for_developers
Keywords: dev-doc-needed
Whoo -- that's a huge patch to look through. What's the scoop here? Merging interfaces together? Faster to ask for more details than to pore over all that myself. :)
Whiteboard: [doc-waiting-info]
The only change visible outside the docshell implementation is that the "@mozilla.org/webshell;1" contract no longer exists and has been replaced by the "@mozilla.org/docshell;1" contract.  Since using this contract without creating security holes is more or less rocket science, I'm a little saddened that someone noticed.  :(

Similarly, the webshell CID is gone and one should use a different CID now to get a docshell.
In particular, all the interface changes happened long before this; this was just cleanup of the implementation.
Whiteboard: [doc-waiting-info]
You need to log in before you can comment on or make changes to this bug.