Closed
Bug 491093
Opened 15 years ago
Closed 11 years ago
Add careers buttons page to mozilla.com
Categories
(Websites :: careers.mozilla.org, defect)
Websites
careers.mozilla.org
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: morgamic, Assigned: morgamic)
Details
Attachments
(2 files, 1 obsolete file)
6.00 KB,
patch
|
clouserw
:
review+
|
Details | Diff | Splinter Review |
143.27 KB,
application/x-gzip
|
Details |
Dan wanted a buttons page that people could view to copy/paste buttons onto external websites and get more traffic to our careers/recruiting page.
Assignee | ||
Updated•15 years ago
|
Assignee: nobody → morgamic
Assignee | ||
Comment 1•15 years ago
|
||
v1, let me know what you guys think
Attachment #375430 -
Flags: review?(clouserw)
Comment 2•15 years ago
|
||
Can we put the images under img/ or en-US/img/?
Comment 3•15 years ago
|
||
Comment on attachment 375430 [details] [diff] [review] v1, button page If you can check in the images it would help. r- though because: 1) height is misspelled in the for loop and you're missing a quote 2) all the stuff in <textarea> should be htmlspecialchar()'d 3) For some reason the 3rd image down won't show me the alt-text but I have no idea why. Not blocking on that.
Attachment #375430 -
Flags: review?(clouserw) → review-
Assignee | ||
Comment 4•15 years ago
|
||
Will add some images in a second.
Attachment #375430 -
Attachment is obsolete: true
Attachment #376260 -
Flags: review?(clouserw)
Assignee | ||
Comment 5•15 years ago
|
||
Comment 6•15 years ago
|
||
Comment on attachment 376260 [details] [diff] [review] v2, fixed typo, htmlspecialchars and typo The code looks fine, we just need the images under /en-US/img/careers/
Attachment #376260 -
Flags: review?(clouserw) → review+
Comment 7•13 years ago
|
||
morgamic, is this still relevant?
Updated•12 years ago
|
Component: www.mozilla.org/firefox → www.mozilla.org
Updated•12 years ago
|
Component: www.mozilla.org → General
Product: Websites → www.mozilla.org
Updated•11 years ago
|
Component: General → Other
Product: www.mozilla.org → Websites
Updated•11 years ago
|
Component: Other → careers.mozilla.org
Comment 8•11 years ago
|
||
I do not think this is valid anymore. If it is we can re-open but for now I will close as wontfix. I'll cc Mat on here so at least he is aware.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•