491119 - Recent Discussions does not remove marked spam

Status: VERIFIED FIXED

(Websites Graveyard :: spreadfirefox.com, defect)

Description

[jamey]

view the 6 post on http://www.spreadfirefox.com/recent_discussions from Submitted by zambak on Sat, 05/02/2009 

zambak thanks post links to porn adult content vakiti DOT net

This may be a oversight
to recreate
start on the index <front> page http://www.spreadfirefox.com/

then click on the block region recent discussions "View all postings"
you will end up here
http://www.spreadfirefox.com/recent_discussions

--------------------------------------------------------------------------

As a vanguard normally when I mark it as spam it quarantines it immediately

Then it will give us vanguards the ability to delete or edit such posting.

--------------------------------------------------------------------------

Site wide if its spam is should be removed from viewing from authenticated user and anonymous user

--------------------------------------------------------------------------

Marked spam should not show up on http://www.spreadfirefox.com/recent_discussions at all it could get out of hand in a hurry IMO 

I did not delete the account "yet"

Comment 1

[Mary]

Jamey-?I don't have an Internet connection right now :( is there anyway you can help with this while I am offline?  Unpublish these? Or are they alresady unpublished? 

Alex - can you work on this after the affiliates are one? Thanks!

Comment 2

[jamey]

Mary I will try and delete the accounts NOW

Comment 3

[jamey]

I have temporarily disabled the usage of FCKeditor (WYSIWYG)
we are getting hit from more pron splog it wont stop them but it will help me control it

Comment 4

[Alex Buchanan [:abuchanan]]

(In reply to comment #3)
> I have temporarily disabled the usage of FCKeditor (WYSIWYG)
> we are getting hit from more pron splog it wont stop them but it will help me
> control it

That's not OK.  Please don't make such changes on the production site without confirmation.  Please turn the WYSIWYG back on.

Also, how was it helping you control it?  Is there another way we can help you control it without turning off the WYSIWYG?

Thanks Jamey!

Comment 5

[jamey]

OK its back on Alex

Comment 6

[Mary]

Thanks.  Alex:  Have you been able to play around with this and get it to stop pulling spam?

Comment 7

[Alex Buchanan [:abuchanan]]

I'm checking this out now.

Comment 8

[Alex Buchanan [:abuchanan]]

just an update: I think I found the problem, now I'm testing this.

btw, the problem was that of drupal fail.  In the DB...

status for nodes
1 == published
0 == not published

status for comments
1 == not published
0 == published

go drupal :(

Comment 9

[jamey]

status or updates on recent discussions and recent discussions seems to post only outdated nodes i.e. 2008 with new comments

p.s. the spam and slog is under control on recent discussions
but not the recent published even if a comment is still brings up the outdated node

Comment 10

[jamey]

alex any update on this ? recent discussions is still not posting any new node's

Comment 11

[jamey]

Attachment: screen shoot of recent discussion page

click on any heading will link to a 2008 post

Comment 12

[jamey]

Attachment: screen shoot first heading on recent discussion

this shows the 2008 post

Comment 13

[Mary]

Ok, per our IM conversation, you and Paul are going to create something on stage akin to recent discussions that will leave out spam?

Thanks for tackling this!

Comment 14

[jamey]

mary nothing will leave out spam 
only simple daily moderation that I do 7 days a week.
or not published anything before being approved that would be a bit extreme IMO

99.9% of our daily spam goes on recent discussion 99.9% of the spam "splog" is on comments to date sfx should be 100% spam free

1% is a stared from a doc or project that is always removed we may get some from the new party events page but none at this time;)

Comment 15

[Mary]

Hey Jamey:  I understand.  When we chatted on IM you thought you had a better solution that what was currently in place.  I believe it was tracker.  If you want to implement this on stage, let's do it :)

Comment 16

[jamey]

I talked to paul a few days ago about it may got lost because of mixed or crossed messages

after I talked to you then we the big launch we all got very busy 
ping him 

hi did tell me he was going to look at alex code ill see if I can get him to reply today

Comment 17

[Alex Buchanan [:abuchanan]]

Jamey, please do not change target milestones unless you've OK'd it with the people who are managing a project's timeline.  In the case of SFx, that's usually Mary or myself.  3.0.2 is done and we're triaging bugs for 3.0.3.  When you move them, it's confusing.

(In reply to comment #16)
> I talked to paul a few days ago about it may got lost because of mixed or
> crossed messages
> 
> after I talked to you then we the big launch we all got very busy 
> ping him 
> 
> hi did tell me he was going to look at alex code ill see if I can get him to
> reply today

Also, please please, for the sake of my sanity, proof read your comments and emails before you send them.  The above text is really hard to understand.  

If you and Paul have a solution for recent discussions based on the tracker, I would love to try it!  Please let us know.

Thanks!

Comment 18

[Paul Booker]

@Jamey,

I don't recall saying that i was going to take a look at Alex's code. The last
time we communicated on this i think i said it was not clear to me what the
problem was from what you had said previously.

@Mary / Alex

Would you clarify the problem (for me) and if there is a problem whether you
need any assistance.  

Best, Paul

Comment 19

[Alex Buchanan [:abuchanan]]

The problem is that posts that are marked as spam are showing up in the recent discussions block on the home page.

That problems stems from the code I wrote to gather recent discussions for that block, it doesn't take spam into account.

There was mention of using the existing Drupal code (the code used for spreadfirefox.com/tracker) instead of my code, to gather these recent discussions.

Options are,

a) fix my code so that it takes spam into account,
b) set up a demo of the /tracker idea, and show that it can be used for the home page block.

Does that clear it up?

Comment 20

[jamey]

Alex I did not change a think you got something wrong again just delete me from this bug thank you

Comment 21

[Mary]

Hey there:  Let's all settle down :)

Jamey/Paul:  Please set up a demo if you have the time.  Thanks!

Comment 22

[Otto de Voogd [:ottodv]]

I suspect this bug has a relation to bug 493632 or at least the same modules are affected, and so trying to solve one may help resolve the other.

Comment 23

[Alex Buchanan [:abuchanan]]

this should be fixed on stage, along with bug 493632

Comment 24

[raymond [:retornam] (inactive)]

https://spreadfirefox.authstage.mozilla.com/recent_discussions returns a page not found. https://spreadfirefox.com/recent_discussions however  works as it should. I am reopening this bug because  comment #23 mentioned that  it was fixed on stage

Comment 25

[Alex Buchanan [:abuchanan]]

The recent discussions page no longer exists, because it has been split into two separate pages, recent_replies and new_discussions

Comment 26

[raymond [:retornam] (inactive)]

verified fixed based on comment #25