491190 - fix miscellaneous warnings in networking modules

Status: RESOLVED DUPLICATE of bug 745296

(Core :: Networking, defect)

Comment 1

[timeless]

Attachment: wrong patch

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 375515 [details] [diff] [review]
wrong patch

this patch is identical to attachment 375514 [details] [diff] [review], you probably meant to attach a different one to this bug?

Comment 3

[timeless]

Attachment: patch

Comment 4

[timeless]

Attachment: updated

Comment 5

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 384278 [details] [diff] [review]
updated

+++ b/modules/libjar/nsJARInputStream.cpp
+                if ((PRUint32)bytesRead != aCount) {

can you use a constructor-style cast instead? (if (PRUint32(bytesRead) ...))

+++ b/modules/libjar/nsZipArchive.cpp
+      if ((PRUint32)byteCount < (namelen + extralen + commentlen + sizeof(sig))) {

here too

+++ b/netwerk/build/nsNetModule.cpp
+#undef assert

why this?

+++ b/netwerk/streamconv/converters/mozTXTToHTMLConv.cpp
+  if (aInLength < 0 || pos >= (PRUint32) aInLength) {

constructor-style cast

+        (nsCRT::IsAsciiAlpha(lastChar = aInString[i]) ||
+         nsCRT::IsAsciiDigit(lastChar)))

I think it would be better to just use aInString[i] in both these lines and not change lastChar.

+  PRInt32 index;

why declare that up here?

+++ b/netwerk/streamconv/src/nsAppleFileDecoder.cpp
-        long count = dataCount;
+        SInt32 count = dataCount;
+        if (noErr != FSWrite(m_rfRefNum, &count, buffPtr) ||
+            (PRUint32) count != dataCount)

Does this meean that the documentation is incorrect?
http://developer.apple.com/documentation/mac/devices/Devices-33.html

+++ b/netwerk/streamconv/src/nsAppleFileDecoder.h
-#define NUM_ENTRIES 		6
+#define NUM_ENTRIES    	    6

if you're removing tabs on other lines, remove them here as well? :)

Comment 6

[Christian :Biesinger (don't email me, ping me on IRC)]

oh... ignore the first two comments, looks like libjar doesn't really do that style of casts

Comment 7

[Jason Duell]

We're getting rid of necko warnings in bug 745296