491269 - Test that editing folder name in bookmarks properties dialog does not accept the dialog

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

we should add a test for this in browser_bookmarksProperties.js, noticed missing in bug 491221.

Comment 1

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Attachment: patch v1.0

this works upon patch in bug 422181 (i'll review it soon), since i need a places command to add a bookmark on an history page.
For this reason won't make 3.5, but would be cool to have this on 3.6 to test for changes in bug 491221.

Comment 2

[Drew Willcoxon :adw]

Comment on attachment 376089 [details] [diff] [review]
patch v1.0

>+    var windowObserver = {
>+      observe: function(aSubject, aTopic, aData) {
>+        if (aTopic === "domwindowclosed") {
>+          ww.unregisterNotification(this);
>+          ok(self._cleanShutdown,
>+             "Dialog window should not be closed by editing a folder name in folder tree");

"Dialog window should not be closed by pressing Esc in folder name textbox..."

Looks good, but I'd like to run it here when bug 422181 is done.  Thanks for cleaning up the other parts in the file.

Comment 3

[Drew Willcoxon :adw]

Comment on attachment 376089 [details] [diff] [review]
patch v1.0

+    folderTree.addEventListener("DOMAttrModified", function onDOMAttrModified(event) {
+        if (event.attrName != "place")
+          return;
+        folderTree.removeEventListener("DOMAttrModified", arguments.callee, false);
+        executeSoon(function () {
+            // Create a new folder.
+            var newFolderButton = self.window.document.getElementById("editBMPanel_newFolderButton");
+            newFolderButton.doCommand();
+            ok(folderTree.hasAttribute("editing"),
+               "We are editing new folder name in folder tree");
+
+            // Press Escape to discard editing new folder name.
+            EventUtils.synthesizeKey("VK_ESCAPE", {}, self.window);
+            ok(!folderTree.hasAttribute("editing"),
+               "We have finished editing folder name in folder tree");
+            self._cleanShutdown = true;
+            self.window.document.documentElement.cancelDialog();
+          });
+      }, false);
+    foldersExpander.doCommand();
+  },

Too much indentation for both the addEventListener and executeSoon callbacks.  With that and the nit in comment 2, r=adw.

Comment 4

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Attachment: patch v1.1

http://hg.mozilla.org/mozilla-central/rev/6c2c6ce6149d

Comment 5

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

since bug 422181 can't make 1.9.1 (l10n changes), this can't make 1.9.1