491361 - Make it impossible for a GCHeap allocation to not get profiled

Status: RESOLVED WONTFIX

(Tamarin Graveyard :: Garbage Collection (mmGC), defect)

Description

[Tommy Reilly]

Just had a thought on how to make the profiler more sturdy.   I'm worried about making sure the profiler is accounting for everything. In DumpFatties we could mark each page we see (set a bit in HeapBlock) and print an error if an in use block isn't marked (we could print out the block alloc trace too).

Note that this has to be conservative as some memory addresses the profiler tracks might not come from MMgc.

Comment 1

[Tommy Reilly]

This is silly, the code should be organized so that its not possible to allocate GCHeap memory without it being profiled, ie just make the fragile code bullet proof and this need goes away.  Changing bug description.

Comment 2

[Tommy Reilly]

Right now we have this fragile model where the "profile" flag is passed to the GCHeap telling it whether to tell the profiler about it.   The profiler should be told about all GCHeap allocations and sub-page allocations should tell the profiler they are sub page allocations and the memory profiler should sort it all out.

Comment 3

[Sylvestre Ledru [:Sylvestre]]

Tamarin is a dead project now. Mass WONTFIX.

Comment 4

[Sylvestre Ledru [:Sylvestre]]

Tamarin isn't maintained anymore. WONTFIX remaining bugs.