Closed
Bug 491477
Opened 16 years ago
Closed 16 years ago
Add support in repack script to disable migration wizard in partner repacks
Categories
(Release Engineering :: Release Requests, defect, P2)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: kev, Assigned: coop)
Details
Attachments
(2 files)
30 bytes,
text/plain
|
Details | |
5.35 KB,
patch
|
nthomas
:
review+
|
Details | Diff | Splinter Review |
With some distributions of Firefox (i.e. OEM images), the migration wizard is not required/desired on firstrun. The repack script does not currently support the ability to create a partner repack with the migration wizard disabled, and this bug is a feature enhancement request to enable this support.
The proposed mechanic for disabling the migration wizard is to add a boolean "migrationWizardDisabled" config directive to the repack.cfg file. Setting the value to "true" would create a repack with the migration wizard disabled. The default value should be "false".
If the "migrationWizardDisabled" directive is "true", then the attached override.ini file should be added (it should never exist by default) to the platform's relevant installer directory ( /firefox for linux-i686, /Firefox/Firefox.app/Contents/MacOS for mac, /nonlocalized for win32 ).
Reporter | ||
Comment 1•16 years ago
|
||
Would probably help if I indicated which script I was talking about :)
partner-repacks.py , which can be viewed at:
http://hg.mozilla.org/build/partner-repacks/file/241d21dff2d5/scripts/partner-repacks.py
Assignee | ||
Comment 2•16 years ago
|
||
(In reply to comment #1)
> Would probably help if I indicated which script I was talking about :)
I think I could have figured it out. ;)
Status: NEW → ASSIGNED
Priority: -- → P2
Assignee | ||
Comment 3•16 years ago
|
||
I pass the config struct to the Repack* classes now in case we have more toggles in the future.
Attachment #376274 -
Flags: review?(nthomas)
Comment 4•16 years ago
|
||
Comment on attachment 376274 [details] [diff] [review]
Create an override.ini file when specified
>+ def createOverrideIni(self, partner_path):
>+ ''' Some partners need to override the migration wizard. This is done
>+ by adding an override.ini file to the base install dir.
>+ '''
>+ filename='%s/override.ini' % partner_path
>+ if self.repack_info.has_key('migrationWizardDisabled'):
>+ if not os.path.isfile(filename):
Looks fine, except for failing silently in the (admittedly unlikely) event that the original build adds an override.ini.
Attachment #376274 -
Flags: review?(nthomas) → review+
Assignee | ||
Comment 5•16 years ago
|
||
(In reply to comment #4)
> Looks fine, except for failing silently in the (admittedly unlikely) event that
> the original build adds an override.ini.
Yeah, I can't see us ever doing that for a core build.
changeset: 9:e0ef6a9cc1f4
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Updated•12 years ago
|
Component: Release Engineering: Custom Builds → Release Engineering: Releases
Updated•12 years ago
|
Product: mozilla.org → Release Engineering
You need to log in
before you can comment on or make changes to this bug.
Description
•