491480 - Ts regression on 2009-05-04

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

There is a small Ts regression, probably caused by bug 477624. The addition of an <arrowscrollbox> (native frame) might be the cause.

Changeset: http://hg.mozilla.org/mobile-browser/rev/4cb6fde71184
Graph: http://graphs.mozilla.org/#show=2774468,2774466,2774464&sel=1241438769,1241528673

I notice that the popup_autocomplete is not marked "hidden=true" and I wonder if doing so would help.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Hmm, I guess we lost the hidden=true at some point, I could have sworn we'd fixed that when we used an actual popup.

Is optimizing for startup over first-open actually desirable here, though? It can already take a while to appear the first time...

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

I added the hidden=true back as part of the theme-based Ts regression. It didn't seem to affect display-time. With the hidden part and the reworked theme, we made up more Ts than we lost:

http://graphs.mozilla.org/#show=2774468,2774466,2774464&sel=1241419016,1241769093