Deadlock detector breaking mac fennec build

RESOLVED FIXED

Status

defect
RESOLVED FIXED
10 years ago
6 years ago

People

(Reporter: ndaversa, Assigned: benjamin)

Tracking

Trunk
All
macOS
Dependency tree / graph
Bug Flags:
wanted-fennec1.0 ?

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

see http://pastebin.mozilla.org/646896 for build output
Flags: wanted-fennec1.0?
tracking-fennec: --- → ?
This is weird. I just finished building an hour before this on my OS X 10.5.6 machine.
Blocks: 456272
(In reply to comment #1)
> This is weird. I just finished building an hour before this on my OS X 10.5.6
> machine.

You mean it worked an hour ago, but doesn't any more?  Or is it still working for you?
It worked an hour before and it worked just now when I tried (and succeeded) in building again. No error messages.

I'm not building debug though. Perhaps that is the issue?
(In reply to comment #3)
> It worked an hour before and it worked just now when I tried (and succeeded) in
> building again. No error messages.
> 
> I'm not building debug though. Perhaps that is the issue?

Yes, this code is not built for DEBUG.
I get the similar errors on FreeBSD and Linux (Ubuntu).  Building DEBUG.  Does this need a clobber build?
Sorry, that should have said, building firefox (not fennec)
(In reply to comment #5)
> I get the similar errors on FreeBSD and Linux (Ubuntu).  Building DEBUG.  Does
> this need a clobber build?

Can you try a clobber build and see if this goes away?  I don't have much idea right now what's wrong.
Most likely an --enable-libxul issue. I think that changes whether or not the tests are built with the MOZILLA_INTERNAL_API flag.
Posted patch Fix (obsolete) — Splinter Review
Nino or Jeremy, can you please post your .mozconfigs so I can test this patch?

If I can't test today, this may remain broken until next Tuesday because I'm going on vacation.
Assignee: nobody → jones.chris.g
It will need to be backed out
chris, to test, just add --enable-libxul to your debug firefox build.
I just did a clobber build and everything worked fine.

This is the mozconfig i'm using...
http://pastebin.mozilla.org/646974
(In reply to comment #12)
> I just did a clobber build and everything worked fine.
> 

A clobber build, but without applying the patch above?  If you didn't apply the patch, and --enable-libxul was the issue, it still shouldn't have worked ...
i just updated my tree before i built, I didn't apply the patch here, nor did I have --enable-libxul, but it builds and runs for me, I was just using it.

Let me know what I can do to help debug.
(In reply to comment #14)
> i just updated my tree before i built, I didn't apply the patch here, nor did I
> have --enable-libxul, but it builds and runs for me, I was just using it.
> 

Does the option "mobile --with-libxul-sdk=..." imply "--enable-libxul"?
Never mind.  I repro'd this with --enable-libxul, seeing if my fix is correct ...
OK, it works.  I'm going to see if I can check this in without bsmedberg's r+ ...
Attachment #375913 - Attachment description: Probable fix → Fix
Attachment #375913 - Flags: review?(benjamin)
Advised not to check in without review.  The workaround until then is to apply the patch here.
I'm going to commit this alternate fix: there are slight variations in the signature of .Find() between the internal and external string API... we should build the test in both configurations, and just account for the differences.
Assignee: jones.chris.g → benjamin
Attachment #375913 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #375913 - Flags: review?(benjamin)
http://hg.mozilla.org/mozilla-central/rev/5b6ce32aeab3
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
tracking-fennec: ? → ---
You need to log in before you can comment on or make changes to this bug.