The default bug view has changed. See this FAQ.

Convert ns{Int,}{Point,Size,Margin,Rect} to typedefs

RESOLVED FIXED

Status

()

Core
Graphics
--
enhancement
RESOLVED FIXED
8 years ago
6 years ago

People

(Reporter: zwol, Unassigned)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

8 years ago
Bug 470506 collapsed the nsPoint/nsIntPoint, nsSize/nsIntSize, etc. class pairs together using templates, but leaves the types nsPoint/nsIntPoint etc as subclasses of the template base class, which requires a bunch of boilerplate to define constructors again and so on.

The types used in general code should be converted to typedefs (adding a dummy template parameter to the base class so that when NS_COORD_IS_FLOAT is not defined, the two members of each pair are still not the same type), and all places that currently forward-declare one of these classes should be changed to include the appropriate headers instead.
(Reporter)

Updated

8 years ago
No longer depends on: 470506
(Reporter)

Updated

8 years ago
Depends on: 470506
(Reporter)

Comment 1

7 years ago
I no longer work for Mozilla.  Deassigning myself from bugs I don't intend to work on as a volunteer.
Assignee: zackw → nobody
Status: ASSIGNED → NEW
We unified these classes.
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.