Closed Bug 49159 Opened 20 years ago Closed 11 years ago

nice_html_only_p always FALSE, can be removed

Categories

(MailNews Core :: MIME, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.0b2

People

(Reporter: BenB, Assigned: mkmelin)

References

Details

Attachments

(1 file)

nice_html_only_p
<http://lxr.mozilla.org/seamonkey/search?string=nice_html_only_p> is
queried, but never initialized
Status: NEW → ASSIGNED
Target Milestone: --- → M18
Target Milestone: M18 → M20
Target Milestone: M20 → mozilla0.9.1
There is more lurking around that lines referenced above.
Blocks: 59673
Changing personal priorities. Giving away most of my bugs :-( (reassigning to
default owner).

I will still track these bugs closely. If you need my input, feel free to ask me.

New owner: Please do *not* close these bugs (as WONTFIX or whatever you may
find) unless they are fixed. Rather, reassign to <nobody@mozilla.org>, if you
don't want to work on them.
Assignee: mozilla → rhp
Status: ASSIGNED → NEW
QA Contact: lchiang → esther
Target Milestone: mozilla0.9.1 → ---
reassigning to ducarroz
Assignee: rhp → ducarroz
Status: NEW → ASSIGNED
Summary: nice_html_only_p not initialized → nice_html_only_p always FALSE, can be removed
Target Milestone: --- → mozilla0.9.6
moving to 1.0
Target Milestone: mozilla0.9.6 → mozilla1.0
Target Milestone: mozilla1.0 → Future
Product: MailNews → Core
Assignee: ducarroz → nobody
Status: ASSIGNED → NEW
QA Contact: esther → mime
Product: Core → MailNews Core
Priority: P3 → --
Target Milestone: Future → ---
Attached patch proposed fixSplinter Review
Removes this dead code.
Assignee: nobody → mkmelin+mozilla
Status: NEW → ASSIGNED
Attachment #350368 - Flags: superreview?(bugzilla)
Attachment #350368 - Flags: review?(bugzilla)
Attachment #350368 - Flags: superreview?(bugzilla)
Attachment #350368 - Flags: superreview+
Attachment #350368 - Flags: review?(bugzilla)
Attachment #350368 - Flags: review+
changeset:   1382:f8e9f21778d5
http://hg.mozilla.org/comm-central/rev/f8e9f21778d5

->FIXED
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.0b2
Thanks for fixing this.
As mentioned in the initial description, the other flags in the code around are probably similarly useless. Shall I file a new bug or reopen?
New bug please.
Looking at the other variables around there, they seem to be used, so the rest should be OK.

VERIFIED that nice_html_only_p is removed. Not tested that all still works.
You need to log in before you can comment on or make changes to this bug.