Do not store the buglist sort order of shared saved searches in cookies

RESOLVED FIXED in Bugzilla 3.2

Status

()

Bugzilla
Query/Bug List
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: Frédéric Buclin, Assigned: Frédéric Buclin)

Tracking

3.3.4
Bugzilla 3.2
Bug Flags:
approval +
approval3.4 +
blocking3.4 +
approval3.2 +

Details

Attachments

(1 attachment)

(Assignee)

Description

8 years ago
I cannot believe this bug hasn't been reported yet.

When you run someone else's shared saved searches, or your own saved searches, the sort order for the buglist should not be stored in the LASTORDER cookie. In 100% of cases (+/- 0%), you don't want someone else's sort order to become your default sort order. This happened to me today again, and this really makes me crazy (and most of the time, I avoid running someone else's shared query for this reason).

AFAICS, the fix is a one-liner. Ideally, I would like this fix to land for 3.2 too.
Flags: blocking3.4+
(Assignee)

Comment 1

8 years ago
Created attachment 376007 [details] [diff] [review]
patch, v1

For now, I only ignore other user's shared saved searches. Your own saved searches will still affect the LASTORDER cookie because it's a bit harder to detect correctly what you are doing. I could probably check for

  $cgi->param('cmdtype') eq "dorem"

and leave the LASTORDER cookie alone if true, but I suppose that's not necessary for now, at least on branches.
Attachment #376007 - Flags: review?(ghendricks)

Comment 2

8 years ago
Comment on attachment 376007 [details] [diff] [review]
patch, v1

Ideally, I would like to see default sort stored server side so I don't have to set it on each machine I log in from. But this is a good step.
Attachment #376007 - Flags: review?(ghendricks) → review+
(Assignee)

Updated

8 years ago
Flags: approval3.4+
Flags: approval3.2?
Flags: approval+
(Assignee)

Comment 3

8 years ago
justdave is fine to take it for 3.2.
Flags: approval3.2? → approval3.2+
Target Milestone: Bugzilla 3.4 → Bugzilla 3.2
(Assignee)

Comment 4

8 years ago
tip:

Checking in buglist.cgi;
/cvsroot/mozilla/webtools/bugzilla/buglist.cgi,v  <--  buglist.cgi
new revision: 1.395; previous revision: 1.394
done

3.3.4:

Checking in buglist.cgi;
/cvsroot/mozilla/webtools/bugzilla/buglist.cgi,v  <--  buglist.cgi
new revision: 1.394.2.1; previous revision: 1.394
done

3.2.3:

Checking in buglist.cgi;
/cvsroot/mozilla/webtools/bugzilla/buglist.cgi,v  <--  buglist.cgi
new revision: 1.374.2.9; previous revision: 1.374.2.8
done
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.