Closed Bug 491683 Opened 11 years ago Closed 11 years ago

provide simple mochitest for ARIA grid based on html:table

Categories

(Core :: Disability Access APIs, defect)

defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: surkov, Assigned: surkov)

References

(Blocks 2 open bugs)

Details

Attachments

(1 file, 1 obsolete file)

Attached patch patch (obsolete) — Splinter Review
Marco, could file bugs to make this ARIA grid accessible and please mark them blocking bug 491681.
Attachment #376009 - Flags: review?(marco.zehe)
Attachment #376009 - Flags: review?(david.bolter)
Comment on attachment 376009 [details] [diff] [review]
patch

>+        children: [
>+          {
>+            role: ROLE_TEXT_CONTAINER // thead
>+          },

Why are we not testing for the children here? Are we not exposing th cells at the moment?

>+    <tobdy>

Typo :-)
I just missed this, will fix it.
Attached patch patch2Splinter Review
improved version
Assignee: nobody → surkov.alexander
Attachment #376009 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #376145 - Flags: review?(marco.zehe)
Attachment #376145 - Flags: review?(david.bolter)
Attachment #376009 - Flags: review?(marco.zehe)
Attachment #376009 - Flags: review?(david.bolter)
Comment on attachment 376145 [details] [diff] [review]
patch2

Nice work... one nit:

>+    th {
>+      -moz-box-align: center;
>+      -moz-box-pack: center;
>+      border: 2px solid;
>+      -moz-border-top-colors: ThreeDHighlight ThreeDLightShadow;
>+      -moz-border-right-colors: ThreeDDarkShadow ThreeDShadow;
>+      -moz-border-bottom-colors: ThreeDDarkShadow ThreeDShadow;
>+      -moz-border-left-colors: ThreeDHighlight ThreeDLightShadow;
>+      background-color: -moz-Dialog;
>+      color: -moz-DialogText;
>+      padding: 0px 4px;
>+    }

All this styling seems unecessary.

r=me
Attachment #376145 - Flags: review?(david.bolter) → review+
(In reply to comment #4)

> All this styling seems unecessary.
> 

Sure but it makes th similar with treecol, it makes me happy :)
Comment on attachment 376145 [details] [diff] [review]
patch2

>+    <tobdy>

Still there :-)

r=me with that fixed. Nice work!
Attachment #376145 - Flags: review?(marco.zehe) → review+
(In reply to comment #6)
> (From update of attachment 376145 [details] [diff] [review])
> >+    <tobdy>
> 
> Still there :-)

oops :) Sorry, I forgot. Will fix it.

> 
> r=me with that fixed. Nice work!

Thank you.
http://hg.mozilla.org/mozilla-central/rev/680a579b1faf
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.