491683 - provide simple mochitest for ARIA grid based on html:table

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[alexander :surkov (:asurkov)]

Attachment: patch

Marco, could file bugs to make this ARIA grid accessible and please mark them blocking bug 491681.

Comment 1

[Marco Zehe (:MarcoZ)]

Comment on attachment 376009 [details] [diff] [review]
patch

>+        children: [
>+          {
>+            role: ROLE_TEXT_CONTAINER // thead
>+          },

Why are we not testing for the children here? Are we not exposing th cells at the moment?

>+    <tobdy>

Typo :-)

Comment 2

[alexander :surkov (:asurkov)]

I just missed this, will fix it.

Comment 3

[alexander :surkov (:asurkov)]

Attachment: patch2

improved version

Comment 4

[David Bolter [:davidb] (NeedInfo me for attention)]

Comment on attachment 376145 [details] [diff] [review]
patch2

Nice work... one nit:

>+    th {
>+      -moz-box-align: center;
>+      -moz-box-pack: center;
>+      border: 2px solid;
>+      -moz-border-top-colors: ThreeDHighlight ThreeDLightShadow;
>+      -moz-border-right-colors: ThreeDDarkShadow ThreeDShadow;
>+      -moz-border-bottom-colors: ThreeDDarkShadow ThreeDShadow;
>+      -moz-border-left-colors: ThreeDHighlight ThreeDLightShadow;
>+      background-color: -moz-Dialog;
>+      color: -moz-DialogText;
>+      padding: 0px 4px;
>+    }

All this styling seems unecessary.

r=me

Comment 5

[alexander :surkov (:asurkov)]

(In reply to comment #4)

> All this styling seems unecessary.
> 

Sure but it makes th similar with treecol, it makes me happy :)

Comment 6

[Marco Zehe (:MarcoZ)]

Comment on attachment 376145 [details] [diff] [review]
patch2

>+    <tobdy>

Still there :-)

r=me with that fixed. Nice work!

Comment 7

[alexander :surkov (:asurkov)]

(In reply to comment #6)
> (From update of attachment 376145 [details] [diff] [review])
> >+    <tobdy>
> 
> Still there :-)

oops :) Sorry, I forgot. Will fix it.

> 
> r=me with that fixed. Nice work!

Thank you.

Comment 8

[alexander :surkov (:asurkov)]

http://hg.mozilla.org/mozilla-central/rev/680a579b1faf