491776 - Avoid conversion of size_t to int while calling ChangeSize() in memory profiler code

Status: RESOLVED FIXED

(Tamarin Graveyard :: Garbage Collection (mmGC), defect, P5)

Description

[Rishit Shah]

The conversion could result in truncation and wrapping of the real size.  Simply passing an argument to indicate add/subtract should do.

Comment 1

[Lars T Hansen]

Attachment: Obvious patch

Comment 2

[Felix S. Klock II [:pnkfelix, :fklock]]

Comment on attachment 437621 [details] [diff] [review]
Obvious patch

Compiles, and looks solid.

(But I have not actually tested; I do not know how to exercise the memory profiler yet.)

It looks like the other participants implicitly agree that the payoff for trying to make a test here would not justify the effort of construction.

One nitpick: you used spaces for indentation but the rest of this file uses tabs.  I would favor consistency within the file over isolated introduction of space-based indentation.

Comment 3

[Lars T Hansen]

Thanks.  Nit acknowledged, but as spaces vs tabs is a tool-wide setting in Xcode I'm pretty much screwed and spaces have been slowly creeping into files for the last several months from many of us for that reason.

Comment 4

[Felix S. Klock II [:pnkfelix, :fklock]]

You can tell Xcode to use emacs as your source code editor.  :)

(But I can understand the appeal of sticking with one tool, especially if you know how to use it well.  I am continuing to put off learning Xcode... I do not think I've found anything as good as the Green Hills IDE.)

Comment 5

[Steven Johnson]

(In reply to comment #4)
> You can tell Xcode to use emacs as your source code editor.  :)

I could also drive nails into my hand... :-)

Comment 6

[Lars T Hansen]

tamarin-redux changeset:   4368:99cd238e94d0