Closed Bug 491855 Opened 12 years ago Closed 12 years ago

Enabling CoreText should be explicit, instead of magic based on the SDK

Categories

(Firefox Build System :: General, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.9.2a1

People

(Reporter: benjamin, Assigned: benjamin)

References

Details

Attachments

(1 file, 1 obsolete file)

Our policy with configure options is that non-default options should be explicitly specified, and features should not be selected based solely on configure tests.

To build with coretext we should be using --enable-coretext instead of magically enabling coretext with the 10.5 SDK.
Tested correct behavior with 10.4/10.5 --enable-coretext and not.
Attachment #376239 - Flags: review?(ted.mielczarek)
In the future please have Ted or me review substantive changes to configure such as this.
(In reply to comment #2)
> In the future please have Ted or me review substantive changes to configure
> such as this.

Sorry; relatively new here, and not always sure who should review what, so still trying to learn from those who've been around longer.
(In reply to comment #0)
> Our policy with configure options is that non-default options should be
> explicitly specified, and features should not be selected based solely on
> configure tests.

OK; but the intention is for coretext to become the default (eventually only) option, AFAIK.

> To build with coretext we should be using --enable-coretext instead of
> magically enabling coretext with the 10.5 SDK.

What do you expect to happen when building for 64-bit; should an explicit --enable-coretext still be required?
We can flip the default at an appropriate time.

I think for the time being requiring 64-bit builders to specify --enable-coretext is ok, but we could also set an explicit default for 64-bit.
Please make an explicit default for 64-bit, mozconfigs for that are complicated enough already and ATSUI is not an option at all on 64-bit.
Attachment #376239 - Attachment is obsolete: true
Attachment #376264 - Flags: review?(ted.mielczarek)
Attachment #376239 - Flags: review?(ted.mielczarek)
Attachment #376264 - Flags: review?(ted.mielczarek) → review+
http://hg.mozilla.org/mozilla-central/rev/1507fddc9b51
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Flags: in-testsuite-
Target Milestone: --- → mozilla1.9.2a1
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.