491919 - cert.h doesn't have valid functions prototypes

Status: RESOLVED FIXED

(NSS :: Libraries, defect)

Description

[Kai Engert (:KaiE:)]

Forwarded from https://bugzilla.redhat.com/show_bug.cgi?id=499148

Description of problem:
cert.h doesn't have valid function prototypes. For example
CERT_GetPKIXVerifyNistRevocationPolicy() should be
CERT_GetPKIXVerifyNistRevocationPolicy(void). Attached patch will say you more.

Steps to Reproduce:
1. write main.c with
#include <cert.h>

int main(void) {
  return 0;
}

2.

gcc `pkg-config --libs --cflags nss` -Wstrict-prototypes main.c


Actual results:
/usr/include/nss3/cert.h:1608: warning: function declaration isn’t a prototype
/usr/include/nss3/cert.h:1614: warning: function declaration isn’t a prototype
/usr/include/nss3/cert.h:1620: warning: function declaration isn’t a prototype
/usr/include/nss3/cert.h:1654: warning: function declaration isn’t a prototype

Expected results:
No warnings displayed

Comment 1

[Kai Engert (:KaiE:)]

Attachment: Patch v1

I'm simply forwarding this bug and patch.

If you agree, can you please r+ and commit?
Thanks.

Comment 2

[Alexei Volkov]

Comment on attachment 376295 [details] [diff] [review]
Patch v1

r=alexei

Comment 3

[Julien Pierre]

Checking in cert.h;
/cvsroot/mozilla/security/nss/lib/certdb/cert.h,v  <--  cert.h
new revision: 1.78; previous revision: 1.77
done