Closed
Bug 491919
Opened 17 years ago
Closed 17 years ago
cert.h doesn't have valid functions prototypes
Categories
(NSS :: Libraries, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
3.12.4
People
(Reporter: KaiE, Assigned: julien.pierre)
Details
Attachments
(1 file)
|
1.09 KB,
patch
|
alvolkov.bgs
:
review+
|
Details | Diff | Splinter Review |
Forwarded from https://bugzilla.redhat.com/show_bug.cgi?id=499148
Description of problem:
cert.h doesn't have valid function prototypes. For example
CERT_GetPKIXVerifyNistRevocationPolicy() should be
CERT_GetPKIXVerifyNistRevocationPolicy(void). Attached patch will say you more.
Steps to Reproduce:
1. write main.c with
#include <cert.h>
int main(void) {
return 0;
}
2.
gcc `pkg-config --libs --cflags nss` -Wstrict-prototypes main.c
Actual results:
/usr/include/nss3/cert.h:1608: warning: function declaration isn’t a prototype
/usr/include/nss3/cert.h:1614: warning: function declaration isn’t a prototype
/usr/include/nss3/cert.h:1620: warning: function declaration isn’t a prototype
/usr/include/nss3/cert.h:1654: warning: function declaration isn’t a prototype
Expected results:
No warnings displayed
|
Reporter | |
Comment 1•17 years ago
|
||
I'm simply forwarding this bug and patch.
If you agree, can you please r+ and commit?
Thanks.
Attachment #376295 -
Flags: review?(alexei.volkov.bugs)
|
||
Comment 2•17 years ago
|
||
Comment on attachment 376295 [details] [diff] [review]
Patch v1
r=alexei
Attachment #376295 -
Flags: review?(alexei.volkov.bugs) → review+
|
|
Assignee | |
Comment 3•17 years ago
|
||
Checking in cert.h;
/cvsroot/mozilla/security/nss/lib/certdb/cert.h,v <-- cert.h
new revision: 1.78; previous revision: 1.77
done
Assignee: nobody → julien.pierre.boogz
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Target Milestone: --- → 3.12.4
You need to log in
before you can comment on or make changes to this bug.
Description
•