[FIX]Need more-correct marking of floats with dirty bits on interrupt

RESOLVED FIXED

Status

()

RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: bzbarsky, Assigned: bzbarsky)

Tracking

Trunk
x86
Mac OS X
Points:
---
Bug Flags:
in-testsuite ?

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

The interruptible reflow patch that landed had a small chunk to add dirty bits to floats on interrupt, but now that I look at it again it'll screw up other out-of-flows.  I'm not sure it ever gotr reviewed either; I might have added it as part of the "address review comments" step.

Patch coming up to make it better.
Attachment #376445 - Flags: superreview?(dbaron)
Attachment #376445 - Flags: superreview?
Attachment #376445 - Flags: review?(dbaron)
Attachment #376445 - Flags: review?
Comment on attachment 376445 [details] [diff] [review]
Like so

I guess this is more correct because (1) other out-of-flows aren't reflowed during line reflow so shouldn't be marked dirty here (or something like that??) and (2) some placeholders aren't children of the line, but deeper descendants?

anyway, r+sr=dbaron
Attachment #376445 - Flags: superreview?(dbaron)
Attachment #376445 - Flags: superreview+
Attachment #376445 - Flags: review?(dbaron)
Attachment #376445 - Flags: review+
Yes on both counts.  (1) is especially important, because we'd be scattering dirty bits around without necessarily having all ancestors of the out of flow in question have said dirty bits, which can cause reflows to be silently swallowed.  I'll admit that I hadn't even though of (2)...  Good catch on it.
Pushed http://hg.mozilla.org/mozilla-central/rev/8f559674de11
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Flags: in-testsuite?
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.