Closed Bug 492089 Opened 15 years ago Closed 15 years ago

default Mac OS X minimum deployment target for 64-bit builds should be 10.5

Categories

(Firefox Build System :: General, defect)

x86_64
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.9.2a1

People

(Reporter: jaas, Assigned: jaas)

References

Details

Attachments

(2 files, 2 obsolete files)

The default Mac OS X minimum deployment target for 64-bit builds should be 10.5, not 10.4.
Attached patch fix v1.0 (obsolete) — Splinter Review
Attached patch fix v1.1 (obsolete) — Splinter Review
accidentally included some other changes in the first patch
Attachment #376459 - Attachment is obsolete: true
Attachment #376460 - Flags: review?(ted.mielczarek)
Comment on attachment 376460 [details] [diff] [review]
fix v1.1

+        case "$target" in
+          *64*)

I'd prefer if you were more explicit and used:
case "$target_cpu" in
   x86_64)
Attachment #376460 - Flags: review?(ted.mielczarek) → review+
Attached patch fix v1.2Splinter Review
Attachment #376460 - Attachment is obsolete: true
Blocks: 468509
pushed to mozilla-central

http://hg.mozilla.org/mozilla-central/rev/4f03840f6bde
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Flags: in-testsuite-
Target Milestone: --- → mozilla1.9.2a1
This was ignored in bug 516858 :-/
Attachment #427531 - Flags: review?(bugspam.Callek)
Attachment #427531 - Flags: review?(bugspam.Callek) → review+
Comment on attachment 427531 [details] [diff] [review]
(Bv1) Copy it to comm-central
[Checkin: Comment 7]


http://hg.mozilla.org/comm-central/rev/abeef2125f34
Attachment #427531 - Attachment description: (Bv1) Copy it to comm-central → (Bv1) Copy it to comm-central [Checkin: Comment 7]
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: