Closed
Bug 492131
Opened 15 years ago
Closed 15 years ago
A failure to import a cert from a P12 file leaves error code set to zero
Categories
(NSS :: Libraries, defect, P2)
Tracking
(Not tracked)
RESOLVED
FIXED
3.12.4
People
(Reporter: nelson, Assigned: nelson)
References
Details
Attachments
(1 file)
|
671 bytes,
patch
|
rrelyea
:
review+
|
Details | Diff | Splinter Review |
When sec_pkcs12_add_cert() fails to import a cert for any reason, it does not set the problem flag or the error code in the cert object for the cert that if could not import. Consequently, when all the certs have been processed we know that a failure occurred somewhere, but we don't know in which cert, nor what error occurred. The result is that we report error code zero. That attached patch seems to fix this.
Attachment #376500 -
Flags: review?(rrelyea)
|
Assignee | |
Updated•15 years ago
|
Priority: -- → P2
|
||
Comment 1•15 years ago
|
||
Comment on attachment 376500 [details] [diff] [review] Patch v1 for NSS Trunk r+
Attachment #376500 -
Flags: review?(rrelyea) → review+
|
|
Assignee | |
Comment 2•15 years ago
|
||
Checking in pkcs12/p12d.c; new revision: 1.44; previous revision: 1.43
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•