492390 - credits.xhtml update for 3.5 release

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Johnathan Nightingale [:johnath]]

The addition that started this bug was:

Rob Stradling

but there may well be others.

Comment 1

[Mike Beltzner [:beltzner, not reading bugmail]]

Is this credits in about:credits or credits in About Firefox > Credits ?

Comment 2

[Johnathan Nightingale [:johnath]]

Lord help us all, but we do make this complicated, don't we?  :)  I meant credits.xhtml,

http://mxr.mozilla.org/mozilla-central/source/browser/base/content/credits.xhtml

which gets included in the About Firefox->Credits box. That's the one in-product, managed by mconnor.

about:credits is actually just a redirect to http://www.mozilla.org/credits/, which is maintained by Gerv. He prefers to handle these via email to [e-mail], but I'll cc him here in case it helps him spot people he might have missed (even though the lists are not semantically equivalent).

In the case of Rob, he should be on both lists.

Comment 3

[Dão Gottwald [:dao]]

Graeme McCutcheon
Nochum Sossonko

Comment 4

[Mike Connor [:mconnor]]

Okay, I would ask that people email me nominations, as this isn't something I'm comfortable handling with public nominations.  Thanks.

Comment 5

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

We on track to get an update committed today?

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

Connor, happy to work on this for you if you send me the list ...

Comment 7

[Mike Connor [:mconnor]]

The problem is that I think the list is incredibly short and missing names, the patch itself is trivial...

Comment 8

[Mike Connor [:mconnor]]

Attachment: first rev

Comment 9

[Johnathan Nightingale [:johnath]]

Comment on attachment 378922 [details] [diff] [review]
first rev


>+            <li>David Dahlt</li>

Dahlt -> Dahl

Comment 10

[Mike Connor [:mconnor]]

Pointed out, fixed.  This landed branch/trunk already.

Comment 11

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

yay

Comment 12

[Dão Gottwald [:dao]]

Does "first rev" mean that there's more to come? If so, should this be reopened?

Comment 13

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

Connor indicated (out of band) that he'd be done in a few hours, many many hours ago, so I'm presuming that whatever needed to land has landed.

Comment 14

[Mike Connor [:mconnor]]

No, I got pulled into blocker reviews, but I've got the data for a bunch more contributors.  We shouldn't block on this, but I'll get it together ASAP anyway.

Comment 15

[Mike Connor [:mconnor]]

Attachment: more

Comment 16

[Markus Stange [:mstange]]

"more" still needs to land, right?

Comment 17

[Mike Connor [:mconnor]]

Attachment: even more

"more" landed already, but hadn't

this will land shortly

Comment 18

[Aakash Desai [:aakashd]]

Aakash Desai ?

Comment 19

[Gen Kanai [:gen]]

Tomomi Kato (Mozilla Japan, marketing manager)

Comment 20

[Gen Kanai [:gen]]

Michael Yoshitaka Erlewine (Mozilla Labs, Ubiquity l10n, contractor)

Comment 21

[Reed Loden [:reed]]

Comment on attachment 379232 [details] [diff] [review]
more

>+            <li>Matthew Noorenberghe </li>

Excess space.

Comment 22

[Gen Kanai [:gen]]

from attachment 378922 [details] [diff] [review] 

> @@ -382,16 +386,17 @@
>             <li>Kaori Negoro</li>

Please be sure to delete Kaori Negoro from credits.

Comment 23

[Mike Beltzner [:beltzner, not reading bugmail]]

Attachment: gen and joduinn's edits

Comment 24

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 384631 [details] [diff] [review]
gen and joduinn's edits

(missing some names, mike will update)

Comment 25

[Phil Ringnalda (:philor)]

At least in my alphabet, Gas comes after Gar

Comment 26

[Mike Beltzner [:beltzner, not reading bugmail]]

Attachment: gen and joduinn's edits v2

Aakash & Tomomi added, excess space removed, didn't add Gen's other suggestion as this is Firefox contributors only atm.

Comment 27

[Mike Beltzner [:beltzner, not reading bugmail]]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/1726d2e0d383

Comment 28

[Daniel Holbert [:dholbert]]

If it's not too late, can we also add:
  Keith Schwarz
(He's an intern from last summer who implemented -moz-transform, one of the awesome new CSS features in Firefox 3.5)

Comment 29

[Mike Beltzner [:beltzner, not reading bugmail]]

Well, we're not holding the RC for this, so whatever gets in by the time we lock down, gets in.

Comment 30

[Mike Connor [:mconnor]]

Comment on attachment 384632 [details] [diff] [review]
gen and joduinn's edits v2

r+ for the additions, I made a decision when we started this that we weren't getting into culling the list this cycle, because that's a process that we should either apply across the board or not at all.

Comment 31

[:Gavin Sharp [email: [e-mail]]]

Attachment: more

Comment 32

[:Gavin Sharp [email: [e-mail]]]

https://hg.mozilla.org/releases/mozilla-1.9.1/rev/c597772f0c6c

Comment 33

[:Gavin Sharp [email: [e-mail]]]

Pushed attachment 384747 [details] [diff] [review] with r=mconnor:

https://hg.mozilla.org/releases/mozilla-1.9.1/rev/c597772f0c6c

Comment 34

[Jeff Walden [:Waldo]]

Comment on attachment 384747 [details] [diff] [review]
more

>diff --git a/browser/base/content/credits.xhtml b/browser/base/content/credits.xhtml

>+            <li>Rick Reitmeier</li>

That should be "Rick Reitmaier".

Comment 35

[Mike Beltzner [:beltzner, not reading bugmail]]

I look forward to the change in comment 34 making it along with the rest of this patch on to trunk. This bug is entirely, all-the-way closed for firefox1.9.1. If anyone checks in additional fixes there, they should be prepared to justify why they've done so.

Comment 36

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #35)
> I look forward to the change in comment 34 making it along with the rest of
> this patch on to trunk. This bug is entirely, all-the-way closed for
> firefox1.9.1. If anyone checks in additional fixes there, they should be
> prepared to justify why they've done so.

I checked in a fix for the typo on the 1.9.1 relbranch and tip, and on trunk, so that it will be included *if* we spin rc3build2. I didn't make any additional changes.

Comment 37

[Mike Beltzner [:beltzner, not reading bugmail]]

Gavin: so is this fixed on trunk, then?

Comment 38

[:Gavin Sharp [email: [e-mail]]]

Yeah, I guess so.

Comment 39

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to comment #22)
> from attachment 378922 [details] [diff] [review] 
> 
> > @@ -382,16 +386,17 @@
> >             <li>Kaori Negoro</li>
> 
> Please be sure to delete Kaori Negoro from credits.

He is still in the list. Further I miss Heather Arthur.