Closed
Bug 492625
Opened 16 years ago
Closed 14 years ago
Stop using underscores to start #defines
Categories
(Core :: SQLite and Embedded Database Bindings, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: sdwilsh, Assigned: wesongathedeveloper)
Details
(Whiteboard: [good first bug])
Attachments
(1 file, 1 obsolete file)
|
23.84 KB,
patch
|
Details | Diff | Splinter Review |
See bug 492139 comment 4 for details
|
Reporter | |
Updated•16 years ago
|
Whiteboard: [good first bug]
|
Assignee | |
Comment 1•15 years ago
|
||
Assignee: nobody → wesongathedeveloper
Status: NEW → ASSIGNED
Attachment #416241 -
Flags: review?(vladimir)
Comment on attachment 416241 [details] [diff] [review]
Patch
Old patch, sorry! Change is fine though.
Attachment #416241 -
Flags: review?(vladimir) → review+
|
|
Reporter | |
Updated•15 years ago
|
Keywords: checkin-needed
|
||
Comment 3•15 years ago
|
||
Please update the patch, it doesn't apply anymore in storage/src/mozStorageStatementData.h.
Keywords: checkin-needed
|
|
||
Comment 4•15 years ago
|
||
... and in a few other files, actually.
|
|
Reporter | |
Comment 5•14 years ago
|
||
Saint Wesonga - do you plan on updating this patch?
|
|
Assignee | |
Comment 6•14 years ago
|
||
Yes, I'll post a patch in the next day or two.
|
|
Assignee | |
Comment 7•14 years ago
|
||
My patch removed the underscores at the end of the #defines as well, is there a standard for how those should be (I can see other defines that have trailing underscores).
Attachment #416241 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•14 years ago
|
Keywords: checkin-needed
|
||
Comment 8•14 years ago
|
||
(In reply to comment #7)
> Created an attachment (id=448526) [details]
> Patch
http://hg.mozilla.org/mozilla-central/rev/bed010a947a5
|
||
Updated•3 months ago
|
Product: Toolkit → Core
You need to log in
before you can comment on or make changes to this bug.
Description
•