Closed Bug 492625 Opened 11 years ago Closed 10 years ago

Stop using underscores to start #defines

Categories

(Toolkit :: Storage, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: sdwilsh, Assigned: wesongathedeveloper)

Details

(Whiteboard: [good first bug])

Attachments

(1 file, 1 obsolete file)

See bug 492139 comment 4 for details
Whiteboard: [good first bug]
Attached patch Patch (obsolete) — Splinter Review
Assignee: nobody → wesongathedeveloper
Status: NEW → ASSIGNED
Attachment #416241 - Flags: review?(vladimir)
Comment on attachment 416241 [details] [diff] [review]
Patch

Old patch, sorry!  Change is fine though.
Attachment #416241 - Flags: review?(vladimir) → review+
Keywords: checkin-needed
Please update the patch, it doesn't apply anymore in storage/src/mozStorageStatementData.h.
Keywords: checkin-needed
... and in a few other files, actually.
Saint Wesonga - do you plan on updating this patch?
Yes, I'll post a patch in the next day or two.
Attached patch PatchSplinter Review
My patch removed the underscores at the end of the #defines as well, is there a standard for how those should be (I can see other defines that have trailing underscores).
Attachment #416241 - Attachment is obsolete: true
Keywords: checkin-needed
(In reply to comment #7)
> Created an attachment (id=448526) [details]
> Patch

http://hg.mozilla.org/mozilla-central/rev/bed010a947a5
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.