Closed Bug 492640 Opened 11 years ago Closed 11 years ago

Fix misc js warnings

Categories

(Calendar :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: dbo, Assigned: dbo)

References

Details

Attachments

(1 file)

Attached patch fix - v1Splinter Review
No description provided.
Attachment #376990 - Flags: review?(ssitter)
Assignee: nobody → dbo.moz
Status: NEW → ASSIGNED
Blocks: 483643
Attachment #376990 - Flags: review?(ssitter) → review+
Comment on attachment 376990 [details] [diff] [review]
fix - v1

r=ssitter with minor comments:

>+++ b/calendar/base/content/agenda-listbox.js
>@@ -365,7 +365,7 @@ function addItem(aItem) {
>                 var prevlistItem = complistItem;
>-                var complistItem = complistItem.nextSibling;
>+                complistItem = complistItem.nextSibling;

prevlistItem seems unused, I'd suggest to remove it.

>+++ b/calendar/providers/storage/calStorageCalendar.js
>@@ -220,6 +220,7 @@ calStorageTimezone.prototype = {
> function getTimezone(aTimezone) {
>+    let tz;

In my opinion variables should always be initialized, please do |let tz = null;| or similar.
done that

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/3a1af5262d96>

-> FIXED
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.0
These bugs are likely targeted at Lightning 1.0b1, not Lightning 1.0. If this change was done in error, please adjust the target milestone to its correct value. To filter on this bugspam, you can use "lightning-10-target-move".
Target Milestone: 1.0 → 1.0b1
You need to log in before you can comment on or make changes to this bug.