492640 - Fix misc js warnings

Status: RESOLVED FIXED

(Calendar :: General, defect)

Description

[Daniel Boelzle [:dbo]]

Attachment: fix - v1

Comment 1

[Stefan Sitter [:ssitter]]

Comment on attachment 376990 [details] [diff] [review]
fix - v1

r=ssitter with minor comments:

>+++ b/calendar/base/content/agenda-listbox.js
>@@ -365,7 +365,7 @@ function addItem(aItem) {
>                 var prevlistItem = complistItem;
>-                var complistItem = complistItem.nextSibling;
>+                complistItem = complistItem.nextSibling;

prevlistItem seems unused, I'd suggest to remove it.

>+++ b/calendar/providers/storage/calStorageCalendar.js
>@@ -220,6 +220,7 @@ calStorageTimezone.prototype = {
> function getTimezone(aTimezone) {
>+    let tz;

In my opinion variables should always be initialized, please do |let tz = null;| or similar.

Comment 2

[Daniel Boelzle [:dbo]]

done that

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/3a1af5262d96>

-> FIXED

Comment 3

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

These bugs are likely targeted at Lightning 1.0b1, not Lightning 1.0. If this change was done in error, please adjust the target milestone to its correct value. To filter on this bugspam, you can use "lightning-10-target-move".