492804 - remove hasAnno check for bookmark description

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Dietrich Ayala (:dietrich)]

Attachment: v1

one less query.

Comment 1

[Marco Bonardo [:mak]]

Comment on attachment 377213 [details] [diff] [review]
v1

>diff --git a/browser/components/places/content/treeView.js b/browser/components/places/content/treeView.js

>       case this.COLUMN_TYPE_DESCRIPTION:
>-        const annos = PlacesUtils.annotations;
>-        if (annos.itemHasAnnotation(node.itemId, DESCRIPTION_ANNO))
>-          return annos.getItemAnnotation(node.itemId, DESCRIPTION_ANNO)
>+        if (node.itemId != -1) {
>+          const annos = PlacesUtils.annotations;

is this really needed?

>+          try {
>+            return annos.getItemAnnotation(node.itemId, DESCRIPTION_ANNO)

missing final semicolon.

>+          }
>+          catch (ex) {
>+            /* has no description */
>+          }

what about making catch on a single line: catch (ex) { /* has no description */ } ? looks like should be easier to follow what code is doing (feel free to ignore me here if you prefer this style)

Comment 2

[Dietrich Ayala (:dietrich)]

Attachment: for checkin

Comment 3

[Marco Bonardo [:mak]]

http://hg.mozilla.org/mozilla-central/rev/95e15728ccae