492843 - Compilation fails with Apples llvm-gcc-4.2

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Nomis101]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10_5_7; de-de) AppleWebKit/528.18.1 (KHTML, like Gecko) Version/4.0 Safari/528.17
Build Identifier: 

I've tried to build Thunderbird with Apples llvm-gcc-4.2 to test if this will give any advantages. But it stoped at sqlite3 with a strange error. I didn't test this but I assume that it will give the same error for firefox.
So it would be nice if the mozilla code could be made compatible with Apples llvm-gcc-4.2.

Reproducible: Always




I used this mozconfig:


# Options for architekture and compiler
CC="llvm-gcc-4.2"
CXX="llvm-g++-4.2"

# Options for client.mk.
mk_add_options MOZ_MAKE_FLAGS=-j4
mk_add_options MOZ_OBJDIR=@TOPSRCDIR@/obj-@CONFIG_GUESS@
mk_add_options AUTOCONF=autoconf213

# Options for 'configure' (same as command-line options).
ac_add_options --with-macos-sdk=/Developer/SDKs/MacOSX10.5.sdk
ac_add_options --enable-application=mail
ac_add_options --enable-static
ac_add_options --enable-update-packaging
ac_add_options --enable-update-channel=nightly
ac_add_options --enable-optimize
ac_add_options --disable-shared
ac_add_options --disable-debug
ac_add_options --disable-tests

Comment 1

[Nomis101]

Attachment: This is the sqlite3 build error

Comment 2

[Matthias Versen [:Matti]]

>So it would be nice if the mozilla code could be made compatible with Apples
>llvm-gcc-4.2.

Sqlite isn't our code...

Comment 3

[Nomis101]

(In reply to comment #2)
> >So it would be nice if the mozilla code could be made compatible with Apples
> >llvm-gcc-4.2.
> 
> Sqlite isn't our code...

Hm, OK. I also opened sqlite - Ticket #3860 for this. 
I hope sqlite3 is the only impediment to build with Apples llvm-gcc-4.2.

Comment 4

[D. Richard Hipp]

This is a compiler bug.  But as a fix from Apple is unlikely to be forthcoming,
I will try to devise a work-around.

Comment 5

[D. Richard Hipp]

There is a patch at http://www.sqlite.org/cvstrac/chngview?cn=6641 that seems likely to work, but I have no way of testing it.  Can someone with access to the llvm-gcc-4.2 compiler please apply the patch and try to compile with it and let me know whether or not it works.  If you want me to send you a copy of the latest amalgamated SQLite sources (including the patch) please contact me via private email.  Tnx.

Comment 6

[Nomis101]

Attachment: Buildlog with the patch

(In reply to comment #5)
> There is a patch at http://www.sqlite.org/cvstrac/chngview?cn=6641 that seems
> likely to work, but I have no way of testing it.  Can someone with access to
> the llvm-gcc-4.2 compiler please apply the patch and try to compile with it and
> let me know whether or not it works.

Thanks for the patch. I've tried your patch with llvm-gcc-4.2. But I don't have large-scaled experiences with sqlite3. So I don't know what it should look like. But I attached my buildlog, so you can look yourself if this is what it should look like.

Comment 7

[D. Richard Hipp]

This problem is such that if it builds without a compiler error, it very
likely works.  So since you managed to get a clean build, I'd say you can
probably close this bug.

Comment 8

[Nomis101]

Yes, with the patch from Comment5 I now get a clean Mozilla build. But this patch is not yet applied on the code, isn't it? So as soon as the patch is applied (if it will) and it is possible to get a clean build with the regular code, this bug can be closed.
FYI, with this patch I'am able to get a clean build, but the build doesn't start (crash on startup). But this has nothing to do with this Bug (and can be handled in a followup).

Comment 9

[D. Richard Hipp]

The patch has already been applied to the SQLite source tree (see http://www.sqlite.org/cvstrac/chngview?cn=6641 if you are interested) and will appear in the next release of SQLite.

The arrangements for integrating new SQLite releases in to Thunderbird are outside of my purview.  Someone else will have to deal with that aspect.

Comment 10

[Shawn Wilsher :sdwilsh]

We haven't yet upgrade to SQLite 3.6.14 yet (maybe this week), but that won't contain this fix.

Comment 11

[Nomis101]

This is fixed now since the checkin of Bug 508104 which updates to SQLite 3.6.16 (includes the fix from Comment #5). I've tested this successfully today with Firefox 3.6a1pre and Thunderbird 3.1a1pre (Mac OS X 10.5.7, X86).

But the applications doesn't start, I will make a followup for this and attach the crash reports.