492852 - Allow branchName to be passed to build factory

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Robert Kaiser]

We're currently assuming that branchName for build factories is the last part of the path of the repoPath passed to the factory, and base several things, like paths for logs, hourly and nightly builds as well as triggered factory names on that.
When building different configs of builds from the same top-level repo, like with comm-central importing mozilla-1.9.1 or mozilla-central, this is not quite what we want, so we need a chance to pass in a different value as branchName.

Comment 1

[Robert Kaiser]

Attachment: allow passing branchName

This patch allows us to pass in a branchName but still falls back to what we did previously, so existing configs should not be affected.

Comment 2

[[e-mail] (:bhearsum)]

Comment on attachment 377255 [details] [diff] [review]
allow passing branchName

Looks fine, and safe.

Comment 3

[[e-mail] (:bhearsum)]

Comment on attachment 377255 [details] [diff] [review]
allow passing branchName

changeset:   286:58aea7b55efd

Comment 4

[Robert Kaiser]

Checked in, so should be fixed - the new SeaMonkey buildbots have been running with this locally applied and passing branchName=branch for a few days and everything looks good. :)

Comment 5

[Robert Kaiser]

Sorry, branchName=name in the master.cfg, of course.