492898 - Stop using compiler-specific macros in freebl

Status: RESOLVED FIXED

(NSS :: Libraries, defect, P3)

Description

[Julien Pierre]

This is a follow-up to bug 485527 . One of the requests from Nelson that I chose to defer was :

[quote]

4. Eliminates all references in all .c .h .s .S and .asm files (in freebl, 
at least) to any and all other symbols for x86 family CPUs, including 
(but not limited to):
    __i386
    __i386__
    _M_IX86
    __x86_64
    __x86_64__
    _M_AMD64
substituting tests for the symbols I described above instead.

The problem with that plethora of compiler-defined symbols (named in item 4 
above) is that they are NOT common to all the build systems (compilers)
that build for a common underlying Instruction Set Architecture (ISA).
The main point is to stop using those uncommon symbols, and start using a 
SMALL set of portable symbols that we define, which are common to all 
platforms of a given ISA. 

[unquote]

Comment 1

[Julien Pierre]

Note that most of these compiler macros are used in mpi . If we remove them and replace them with the freebl macros NSS_X86, NSS_X64, and NSS_X86_OR_X64, then it will no longer be possible to build freebl standalone, unless the standalone makefiles are all changed too.