492985 - No c-c L10n builds since 05/11/09

Status: RESOLVED FIXED

(Mozilla Messaging Graveyard :: Server Operations, defect)

Description

[Vlado Valastiak [:wladow]]

Our L10n builds are missing from Thunderbird and Sunbird tinderboxen since 05/11/09. The latest L10n builds delivered to FTP's nightly folder have the same timestamp.

Comment 1

[Philippe M. Chiasson (:gozer)]

looks like a side effect of bug 487493. Small, simple fix in place, let's see if it works.

Comment 2

[Philippe M. Chiasson (:gozer)]

The exception thrown was:

  File "[python-home]/twisted/internet/defer.py", line 229, in callback
    self._startRunCallbacks(result)
  File "[python-home]/twisted/internet/defer.py", line 294, in _startRunCallbacks
    self._runCallbacks()
  File "[python-home]/twisted/internet/defer.py", line 307, in _runCallbacks
    self.result = callback(self.result, *args, **kw)
  File "[python-home]/buildbot/process/builder.py", line 766, in _startBuild_2
    d = build.startBuild(bs, self.expectations, sb)
--- <exception caught here> ---
  File "[python-home]/buildbot/process/base.py", line 351, in startBuild
    self.setupBuild(expectations) # create .steps
  File "[python-home]/buildbot/process/base.py", line 406, in setupBuild
    step.setBuild(self)
  File "[python-home]/buildbotcustom/steps/l10n.py", line 18, in setBuild
    build.setProperty('locales', self.locales)
<type 'exceptions.TypeError'>: setProperty() takes exactly 4 arguments (3 given)

Comment 3

[Philippe M. Chiasson (:gozer)]

Attachment: [checked in] fix buildbotcustom.steps.l10n.setBuild use of build.setProperty

Not sure why regular mozilla stuff isn't hit by this, but the fix is simple enough.

Comment 4

[Philippe M. Chiasson (:gozer)]

Locally applied the change and reconfigured buildbot. Also triggered a l10n repack of everything, and so far, looks like it's building.

Comment 5

[[e-mail] (:bhearsum)]

Comment on attachment 377505 [details] [diff] [review]
[checked in] fix buildbotcustom.steps.l10n.setBuild use of build.setProperty

changeset:   287:3e6f132a4541

Comment 6

[Philippe M. Chiasson (:gozer)]

Looks like it worked, I see plenty of l10n builds here:

<http://ftp.mozilla.org/pub/mozilla.org/thunderbird/nightly/latest-trunk-l10n/?C=M;O=D>
and
<http://ftp.mozilla.org/pub/mozilla.org/thunderbird/nightly/latest-comm-central-l10n/?C=M;O=D>