493112 - Rewrite: Manually convert nsComponentManager/xptinfo to use new thread synchronization API

Status: RESOLVED DUPLICATE of bug 645263

(Core :: XPCOM, defect)

Description

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

It uses (the now deprecated) nsAutoLock.lock/unlock extensively, which means porky.py can't rewrite it automatically.  I don't feel comfortable rewriting it by hand.

Assigning to bsmedberg so that he can foist this off on someone else.

Comment 1

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Correction: it was nsComponentManager that I didn't want to rewrite.  xptinfo was somehow involved in that in a way that I no longer remember.

For the record, porky was able to handle these rewrites, it's just that this code extensively used nsAutoMonitor.lock/unlock, which can't be rewritten automatically (easily).

Comment 2

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Attachment: Starting point for a rewrite

Here's what porky came up, both to defend its honor ;) and help out whoever works on this bug.

Comment 3

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

I should add that this patch needs to be applied at the mozilla-central top level using |patch -p0 < xptinfo.patch|.