493121 - Prefs for max_windows_undo and max_tabs_undo should be enforced when setting state

Status: NEW

(Firefox :: Session Restore, defect)

Description

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

Spinning off from bug 491590...

Bug 491590 comment 1 & 2 brought up the point that browser.sessionstore.max_windows_undo and browser.sessionstore.max_tabs_undo are not enforced when we call setBrowserState (and in turn setWindowState).

We should probably do that.

Comment 1

[Dietrich Ayala (:dietrich)]

Would be good to guard against bad extension behavior.

Comment 2

[Mani]

Hey, Is it like I was executing the testcase fx4.0.fft, tabbed testing in testcase 8, I am encountering setting the value of browser.sessionstore.max_tabs_undo to '2' and testing the Recently closed tabs list; only two closed tabs should appear. But, all three are appearing. Is this bug the same one?

Comment 3

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

(In reply to comment #2)
> Hey, Is it like I was executing the testcase fx4.0.fft, tabbed testing in
> testcase 8, I am encountering setting the value of
> browser.sessionstore.max_tabs_undo to '2' and testing the Recently closed tabs
> list; only two closed tabs should appear. But, all three are appearing. Is this
> bug the same one?

No, that's different. Can you please file a new bug?

Comment 4

[Mani]

Yeah..A new bug 651038 has been filed! Thanks!:)