Prefs for max_windows_undo and max_tabs_undo should be enforced when setting state

NEW
Unassigned

Status

()

Firefox
Session Restore
9 years ago
7 years ago

People

(Reporter: zpao, Unassigned)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Spinning off from bug 491590...

Bug 491590 comment 1 & 2 brought up the point that browser.sessionstore.max_windows_undo and browser.sessionstore.max_tabs_undo are not enforced when we call setBrowserState (and in turn setWindowState).

We should probably do that.
Would be good to guard against bad extension behavior.
Severity: minor → normal

Comment 2

7 years ago
Hey, Is it like I was executing the testcase fx4.0.fft, tabbed testing in testcase 8, I am encountering setting the value of browser.sessionstore.max_tabs_undo to '2' and testing the Recently closed tabs list; only two closed tabs should appear. But, all three are appearing. Is this bug the same one?
(In reply to comment #2)
> Hey, Is it like I was executing the testcase fx4.0.fft, tabbed testing in
> testcase 8, I am encountering setting the value of
> browser.sessionstore.max_tabs_undo to '2' and testing the Recently closed tabs
> list; only two closed tabs should appear. But, all three are appearing. Is this
> bug the same one?

No, that's different. Can you please file a new bug?

Comment 4

7 years ago
Yeah..A new bug 651038 has been filed! Thanks!:)
You need to log in before you can comment on or make changes to this bug.