Closed Bug 493132 Opened 15 years ago Closed 13 years ago

Rewrite: Upgrade htmlparser/ to new synchronization API

Categories

(Core :: DOM: HTML Parser, defect)

x86
Linux
defect
Not set
normal

Tracking

()

RESOLVED DUPLICATE of bug 645263

People

(Reporter: cjones, Assigned: cjones)

References

Details

Attachments

(1 file)

      No description provided.
Assignee: nobody → jones.chris.g
Attached patch v1Splinter Review
The |Holder| smart pointer is no longer necessary, since Mutex and CondVar can be allocated and freed with new/delete.
Attachment #377583 - Flags: superreview+
Attachment #377583 - Flags: review?(mrbkap)
Attachment #377583 - Flags: review+
Comment on attachment 377583 [details] [diff] [review]
v1

>+    : mLock(0),
>+      mCVar(0),

Nit: remove these.

>-    nsAutoLock al(mLock.get());
>+    MutexAutoLock al(*mLock.get());

Here and below: there's no need for the .get()s anymore.

For the record, we Chris and I talked briefly on IRC about making mLock and mCVar direct members (not pointers). To minimize this patch, I think it's OK if we leave them as nsAutoPtrs for now, though.
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: