Closed
Bug 493132
Opened 16 years ago
Closed 14 years ago
Rewrite: Upgrade htmlparser/ to new synchronization API
Categories
(Core :: DOM: HTML Parser, defect)
Tracking
()
RESOLVED
DUPLICATE
of bug 645263
People
(Reporter: cjones, Assigned: cjones)
References
Details
Attachments
(1 file)
|
5.22 KB,
patch
|
mrbkap
:
review+
mrbkap
:
superreview+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Updated•16 years ago
|
Assignee: nobody → jones.chris.g
|
|
Assignee | |
Comment 1•16 years ago
|
||
The |Holder| smart pointer is no longer necessary, since Mutex and CondVar can be allocated and freed with new/delete.
|
|
Assignee | |
Updated•16 years ago
|
Attachment #377583 -
Flags: review?(mrbkap)
|
||
Updated•15 years ago
|
Attachment #377583 -
Flags: superreview+
Attachment #377583 -
Flags: review?(mrbkap)
Attachment #377583 -
Flags: review+
|
|
||
Comment 2•15 years ago
|
||
Comment on attachment 377583 [details] [diff] [review]
v1
>+ : mLock(0),
>+ mCVar(0),
Nit: remove these.
>- nsAutoLock al(mLock.get());
>+ MutexAutoLock al(*mLock.get());
Here and below: there's no need for the .get()s anymore.
For the record, we Chris and I talked briefly on IRC about making mLock and mCVar direct members (not pointers). To minimize this patch, I think it's OK if we leave them as nsAutoPtrs for now, though.
|
|
Assignee | |
Updated•14 years ago
|
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•