Closed
Bug 493345
Opened 15 years ago
Closed 15 years ago
Compiler warning in jstracer.h: '|' : unsafe mix of type 'uintN' and type 'bool' in operation
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
People
(Reporter: RyanVM, Assigned: gal)
References
Details
(Keywords: fixed1.9.1, Whiteboard: fixed-in-tracemonkey)
Attachments
(1 file, 1 obsolete file)
999 bytes,
patch
|
brendan
:
review+
|
Details | Diff | Splinter Review |
269 void setNativeCallee(JSObject *callee, bool constructing) { 270 nativeCalleeWord = uintN(callee) | constructing; MSVC complains about the comparison between the two being unsafe on line 270.
Assignee | ||
Updated•15 years ago
|
Assignee: general → gal
Comment 1•15 years ago
|
||
You nerds need to use uintptr_t there, and for the type of nativeCalleeWord, yo. /be
Assignee | ||
Comment 2•15 years ago
|
||
Assignee | ||
Comment 3•15 years ago
|
||
Attachment #377817 -
Attachment is obsolete: true
Attachment #377818 -
Flags: review?(brendan)
Updated•15 years ago
|
Attachment #377818 -
Flags: review?(brendan) → review+
Comment 4•15 years ago
|
||
Comment on attachment 377818 [details] [diff] [review] patch Sure, or !!constructing, or even just constructing since C++ defines bool to int fully, IIRC. /be
Assignee | ||
Comment 5•15 years ago
|
||
http://hg.mozilla.org/tracemonkey/rev/c12c8651c10d
Blocks: 492487
Whiteboard: fixed-in-tracemonkey
Assignee | ||
Updated•15 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•