Closed Bug 493360 Opened 15 years ago Closed 13 years ago

Internal links broken in article "Scorciatoie da tastiera di Firefox"

Categories

(support.mozilla.org :: Knowledge Base Articles, task)

task
Not set
normal

Tracking

(Not tracked)

RESOLVED WORKSFORME

People

(Reporter: underpass_bugzilla, Unassigned)

References

()

Details

Attachments

(1 file)

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; it; rv:1.9.0.10) Gecko/2009042315 Firefox/3.0.10
Build Identifier: 

In the article 

https://support.mozilla.com/it/kb/Scorciatoie+da+tastiera+di+Firefox?bl=n

(Italian version of "Keyboard shortcuts") the firts SHOWFOR block breaks wiki links.

The article is organized as follows

1) Introduction
2) First SHOWFOR table block [SHOWFOR(browser=fx3.0, footer=on)}]
3) Second SHOWFOR table block [SHOWFOR(browser=fx3.5, footer=on)}]
4) End

No matter what SHOWFOR table block comes first (3.0 or 3.5), in the first table block the wiki links are not retained and there is a third column (which should not be).

If one of the table block is deleted - no matter which one - the error disappears.

Currently I have chosen to keep broken links in the 3.5 block, but I wish this problem can be solved before Firefox 3.5 is released.

Thanks.

Reproducible: Always
I noticed that the links in the Italian translation are using the format "((Page Zoom|Aumenta zoom))". It looks like the wiki parser incorrectly treats the | character inside of the link as a column separator for the table, which would be a TikiWiki core bug. However, this seems to work fine in the English version of the page (http://support.mozilla.com/en-US/kb/Keyboard+shortcuts), which confuses me.

Could this simply be a syntax error somewhere in the Italian translation? E.g. a missing starting or ending { or similar? It's hard to tell in this complicated article.
Hi David, 

I tried to move the 3.5 block over the 3.0 one and the problem switches to the 3.5. If you delete either of the blocks the problem goes away.

I don't think it is a syntax error.
If you copy the exact text of the en-US version into a new Italian article, does that article have the same bug? If so, this looks like some sort of weird TikiWiki core bug.

If not, this is probably caused by a minor inconsistency, such as a missing character somewhere (but I realize how time consuming finding such an inconsistency can be). :(
Ok, I managed to go slightly ahead (thanks David for your suggestions).

The problem is caused definitively by the first "sub-block", the one that starts with __Navigation__.

I picked the en-us one and simply translated in Italian without moving the rows: no problem.
As soon as I try to sort the elements in alphabetic order, the problem arises.

I ask you to try to sort the rows and substitute the text block in the staging copy (I will attach the file with the text block).

For now I will publish the partial result, because at least it works with both versions of Firefox.
I'll have a look at this this week. We should copy the article source to a sandbox article, then fiddle with it.
If the en-US version were to have those rows in the same order as what the Italian order should be, what would that be?
The order should be:

Open file, Forward, Back, Home, Reload, Reload (override cache), Stop
If I re-order them in the English version (using https://support.mozilla.com/en-US/kb/Article+Sandbox?bl=n ) it still works fine. Maybe there's an unintentional line break.
The problem seems to be with the first line of the en-us article ("Back").
If I remove that line, the problem goes away.

Could you try straightly with the Italian article? The line is the one starting with the word "Indietro".
Chris, in the article you put in the Sandbox I see the same error (with the Firefox 3.0 selector).

I tried to edit the stage copy of the en-us article and manage to duplicate the problem: if the first line ("Back") is moved elsewhere the links are broken and a third column is created.
This looks like a result of the import script (or maybe the original xhtml). If I lay out the tikiwiki markup vertically, and indent it, like HTML I get this:

Back|
  {DIV(class=win,type=span)}
    {DIV(class=noMac kbd,type=span)}Alt{DIV}
    {DIV(class=mac kbd,type=span)}Opt{DIV}
    +
    {DIV(class=kbd,type=span)}Left Arrow{DIV}
    %%% 
    {DIV(class=kbd,type=span)}Backspace{DIV}
  {DIV}
  {DIV(class=unix,type=span)}
    {DIV(class=noMac kbd,type=span)}Alt{DIV}
    {DIV(class=mac kbd,type=span)}Opt{DIV}
    +
    {DIV(class=kbd,type=span)}Left Arrow{DIV}
    %%% 
    {DIV(class=noMac kbd,type=span)}Ctrl{DIV}
    {DIV(class=mac kbd,type=span)}Cmd{DIV}
    +
    {DIV(class=kbd,type=span)}[{DIV}
  {DIV}
  {DIV(class=mac,type=span)}
    {DIV(class=noMac kbd,type=span)}Ctrl{DIV}
    {DIV(class=mac kbd,type=span)}Cmd{DIV}
    +
    {DIV(class=kbd,type=span)}[{DIV}
    %%% 
    {DIV(class=noMac kbd,type=span)}Ctrl{DIV}
    {DIV(class=mac kbd,type=span)}Cmd{DIV}
    +
    {DIV(class=kbd,type=span)}Left Arrow{DIV}
    %%% 
    {DIV(class=kbd,type=span)}Delete{DIV}
  {DIV}

There's a lot that is repeated and necessary. I tried cleaning it up, but still got the same problem. The whole article needs to be redone to use the correct tags and make it easier to edit.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Simone, the keyboard shortcuts article has been reworked with proper {TAG(tag=kbd)} tags by a user named Jarbinks. If you apply those changes to the Italian version, do you still get this bug?
Chris, I surely will try - yet I will need some time (or more than some...) to make all the changes because you know well that this article is absolutely the more difficult to edit and check.

I will keep you informed. :)
Hi Chris, I have worked on the document and the problem is still the same. If I do not sort the rows in alphabetical order, the links are preserver.

As soon as I try to sort them (I used the program PSPAD, just for your info), the links break. You can chech the document, as well as its history:

https://support.mozilla.com/it/kb/*Scorciatoie+da+tastiera+di+Firefox?bl=n
Bear in mind that sorting doesn't work across table rows since the rows aren't all the same.  Some rows have extra || at the end and some have them in the beginning etc.  Also, in your attachment in comment 5, you have an extra space after the |, I'm not sure that's allowed.
Cww: the same issue happens even in the English version, simply putting the "Back" text block after the "Forward" one. You will break all the links in the first part.

Please check this page

https://support-stage.mozilla.org/it/kb/keys+shortcuts+test?bl=n

It's the same as the public one, the only difference being the position of the "Back" text block.

It's most strange.
Looks like the internal links work now.
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: