493364 - can't build with --disable-dbm option when not cross-compiling

Status: RESOLVED FIXED

(NSS :: Build, defect, P2)

Description

[Kouhei Sutou]

User-Agent:       Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.0.10) Gecko Kazehakase/0.5.6
Build Identifier: 

We can't build Linux and Windows (not Windows Mobile) version Fennec (XULRunner) with --disable-dbm option. "Linux and Windows" means that it's not cross-compiling.


Reproducible: Always

Steps to Reproduce:
1. add "ac_add_options --disable-dbm" .mozconfig
2. make -f client.mk build

Actual Results:  
Failed with the following message:
...
make -j1: *** No rule to make target /home/kou/work/mozilla/fennec-clean/xulrunner/dist/lib/libnssdbm3.chk.  Stop.
make[6]: *** [/home/kou/work/mozilla/fennec-clean/xulrunner/dist/lib/libnssdbm3.chk] error 1
...


Expected Results:  
No error.

Comment 1

[Kouhei Sutou]

Attachment: fix the problem.

We don't have nssdbm3.$(DLL_SUFFIX) on --disable-dbm build.

Comment 2

[Nelson Bolyard (seldom reads bugmail)]

Comment on attachment 377837 [details] [diff] [review]
fix the problem.

Please attach a CVS patch,
against the CVS trunk.

Comment 3

[Hiroyuki Ikezoe (:hiro)]

Attachment: CVS diff

I am sorry, I did not notice it.

Comment 4

[Nelson Bolyard (seldom reads bugmail)]

Attachment: related patch

Kouhei & Hiroyuki, 
Would you please test out this tiny patch for the same file and 
inform me if it works satisfactorily for you, together with your patch?
(This patch has windows line endings, so beware. :)

Comment 5

[Nelson Bolyard (seldom reads bugmail)]

Comment on attachment 378204 [details] [diff] [review]
CVS diff

r=nelson

Comment 6

[Hiroyuki Ikezoe (:hiro)]

(In reply to comment #4)

> Kouhei & Hiroyuki, 
> Would you please test out this tiny patch for the same file and 
> inform me if it works satisfactorily for you, together with your patch?
> (This patch has windows line endings, so beware. :)

It could be built fennec for WinXP without errors, and fennec.exe seems to be fine on WinXP. And shlibsign.exe is in dist/bin.

Comment 7

[Nelson Bolyard (seldom reads bugmail)]

Glen, 
Is the file nss/cmd/shlibsign/Makefile part of the frozen FIPS source code?

Comment 8

[Nelson Bolyard (seldom reads bugmail)]

Bob, 
Is the file nss/cmd/shlibsign/Makefile part of the frozen FIPS source code?

Comment 9

[Robert Relyea]

No.

bob

Comment 10

[Nelson Bolyard (seldom reads bugmail)]

Checking in shlibsign/Makefile; new revision: 1.20; previous revision: 1.19