493442 - Weave isn't syncing bookmarks (or anything) other than clients, despite engines being enabled

Status: VERIFIED FIXED

(Firefox :: Sync, defect)

Description

[Darren Worrall]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-GB; rv:1.9.1b4pre) Gecko/20090401 Ubuntu/9.04 (jaunty) Shiretoko/3.5b4pre
Build Identifier: 

Thread here: http://groups.google.com/group/mozilla-labs-weave/browse_thread/thread/c464fea0ac14d447

Only 2 working clients at the moment - Vista running 3.5b4 and Ubuntu
running 3.5b4pre.

The Vista box is syncing fine (odd Undefined item in
tabContainer.childNodes but that's another thread), but the Ubuntu one
is only logging sync attempts in the log for the Clients engine.
Bookmarks (for example) is enabled in prefs and set to true in
about:config, but Weave doesn't even attempt a sync (see log attached).

The boomkarks engine has never been disabled, but I have toggled it and restarted a few times in an attempt to jump start it but without success.



Reproducible: Always

Comment 1

[Darren Worrall]

Attachment: Sync log

Comment 2

[mishail.mishail]

I'm observing the same issue using Firefox 3.5 beta builds from https://launchpad.net/~ubuntu-mozilla-daily/+archive/ppa and Weave 0.3.2.


WinXP clients (with Firefox 3.5b4 and Weave 0.3.2) are working without problems

Comment 3

[mishail.mishail]

I think I've found the root cause. 

Take a look at _registerEngines method:
http://hg.mozilla.org/labs/weave/file/befd9af4df5d/modules/service.js#l397

It expects "Firefox" to be returned by Svc.AppInfo.name. But in my case the value returned by Svc.AppInfo.name is equal to "Firefox-3.5". So no engines are registered.

I've changed "Firefox" to "Firefox-3.5" and after restart all working fine.

I don't know whether it Weave bug or just wrongly packaged Firefox.

Comment 4

[Dan Mills [:thunder]]

Good work, Mikhail.  I would not have guessed to look at the app name!

I'm pretty sure the app name should be "Firefox", not "Firefox-3.5".  There are separate getters to for the app version.  So this would seem to be a packaging bug with the Ubuntu packages.

Keeping this bug open until I confirm tomorrow.

Comment 5

[mishail.mishail]

That value is initialized from application.ini (/usr/lib/firefox-3.5b5pre/application.ini)

[App]
Name=Firefox-3.5

Comment 6

[Darren Worrall]

I can confirm changing the name field in application.ini to just 'Firefox' solves the problem - nice find!

Are you going to report the bug on Launchpad Mikhail, or would you like me to do it?

Comment 7

[mishail.mishail]

(In reply to comment #6)
> I can confirm changing the name field in application.ini to just 'Firefox'
> solves the problem - nice find!
> 
> Are you going to report the bug on Launchpad Mikhail, or would you like me to
> do it?

Go ahead.

Comment 8

[mishail.mishail]

(In reply to comment #6)
BTW, it would be great to know launchpad bug # to track the issue. Could you please let me know its number after submitting? Thanks.

Comment 9

[Darren Worrall]

https://bugs.launchpad.net/ubuntu/+source/firefox-3.5/+bug/377904

:)

Comment 10

[Dan Mills [:thunder]]

Just talked to rstrong about this, he is of the opinion that Weave should not rely on the name, but use the ID instead.

I agree with him, my only remaining question is whether the bug you filed on ubuntu is valid or not (whether they should leave the name alone or not).

For the purposes of this bug, though, using the ID will fix the problem.

Comment 11

[Dan Mills [:thunder]]

Fixes problem in Weave:

http://hg.mozilla.org/labs/weave/rev/4f3fcc54fef6