Closed
Bug 493483
Opened 16 years ago
Closed 16 years ago
"No proxy for" setting doesn't support IPv6 address literals
Categories
(Core :: Networking, defect)
Core
Networking
Tracking
()
RESOLVED
FIXED
mozilla1.9.2b1
People
(Reporter: emk, Assigned: emk)
Details
Attachments
(1 file)
|
1.22 KB,
patch
|
jduell.mcbugs
:
review+
bzbarsky
:
superreview+
|
Details | Diff | Splinter Review |
Subject says all.
Attachment #377970 -
Flags: superreview?(cbiesinger)
Attachment #377970 -
Flags: review?(cbiesinger)
|
||
Updated•16 years ago
|
Attachment #377970 -
Flags: review?(cbiesinger) → review?(jduell.mcbugs)
|
|
||
Updated•16 years ago
|
Attachment #377970 -
Flags: review?(jduell.mcbugs) → review+
|
|
||
Comment 1•16 years ago
|
||
Comment on attachment 377970 [details] [diff] [review]
patch
This looks correct to me (previously, the presence of ':' in IPv6 URIs would incorrectly set PortLocation).
I'm assuming PR_StringToNetAddr takes IPv6 literals (escaped with '[' and ']'): it looks like it from a glance at the code.
Do we need a test here?
Do we need
|
|
||
Comment 2•16 years ago
|
||
Comment on attachment 377970 [details] [diff] [review]
patch
Trying different reviewer.
I'm not sure this even needs superreview, but I'm not as familiar as I'd like with IPv6, so it could use another pair of eyes on it. It's a pretty minor patch.
Attachment #377970 -
Flags: superreview?(cbiesinger) → superreview?(bzbarsky)
|
||
Updated•16 years ago
|
Attachment #377970 -
Flags: superreview?(bzbarsky) → superreview+
|
Assignee | |
Updated•16 years ago
|
Keywords: checkin-needed
|
||
Comment 3•16 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2b1
You need to log in
before you can comment on or make changes to this bug.
Description
•