"Offline Website data" is wrapped to a second line in Settings for Clear History dialog

RESOLVED WONTFIX

Status

()

Firefox
Preferences
--
minor
RESOLVED WONTFIX
9 years ago
9 years ago

People

(Reporter: whimboo, Assigned: Ehsan)

Tracking

({polish, regression})

Trunk
polish, regression
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

9 years ago
Created attachment 377972 [details]
Offline Website Data needs two lines

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090517 Minefield/3.6a1pre ID:20090517031025

With the patch on bug 480898 the entry for "Offline Website data" is wrapped into a second line. See the attached screenshot.
(Reporter)

Updated

9 years ago
Summary: "Offline Website data" is wrapped to a second line in on shutdown settings dialog → "Offline Website data" is wrapped to a second line in Settings for Clear History dialog
(Assignee)

Updated

9 years ago
Assignee: nobody → ehsan.akhgari
Status: NEW → ASSIGNED
Keywords: polish
(Assignee)

Comment 1

9 years ago
This is actually a regression from bug 490655 which made the dialog too narrow without considering the other use of that entity in the Settings for Clear Recent History dialog.
Blocks: 490655
No longer blocks: 480898
(Assignee)

Comment 2

9 years ago
Created attachment 378277 [details] [diff] [review]
Patch (v1)
Attachment #378277 - Flags: review?(johnath)
(Assignee)

Comment 3

9 years ago
Adding [non-l10n-impact string change] here like bug 490655.  Axel, please advise if you don't agree.
Whiteboard: [non-l10n-impact string change]
Attachment #378277 - Flags: review?(johnath) → review+
(Reporter)

Comment 4

9 years ago
Ehsan, when do you plan to check-in this patch?
(Assignee)

Comment 5

9 years ago
I thought the tree rules stated that only patches can land on m-c which are meant to land on 1.9.1 as well...  Am I mistaken?
(Reporter)

Comment 6

9 years ago
No, you are right. Sorry for that.

Comment 7

9 years ago
Ehsan, this has become confusing, but 29em is still too narrow on OS X.  In the 1.9.1 patch at bug 490655 -- which has landed -- I took the 29em number from your patch here.  But if you open up a recent nightly on OS X, the label still wraps as mentioned in this bug.  I should have verified that 29em was OK.

So this is the current state:
- trunk: 28em
- 1.9.1: 29em

And they're both too narrow. :\

I just verified that 31em is the narrowest that works on all three platforms.  (Incidentally that's only 1em smaller than what it originally was before I started with bug 490655...)
(Assignee)

Comment 8

9 years ago
Thanks for the evaluation, Drew.  I think given that this is not likely to land on 1.9.1 at this stage, let's WONTFIX this in favor of bug 494210.
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → WONTFIX
Whiteboard: [non-l10n-impact string change]
You need to log in before you can comment on or make changes to this bug.