493586 - JSON.parse's replacer function can't return undefined

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Simon Bünzli]

Returning undefined is supposed to be used for filtering out specific keys.

Filtering out the "key" key from { key: value } correctly results in "{}" in IE8 but the invalid "{key:}" in Shiretoko (stringify can thus return a string which parse can't handle).

Comment 1

[Robert Sayre]

ugh, embarassing. patch soon.

Comment 2

[Robert Sayre]

Attachment: fix

insidious. source-line test coverage metrics wouldn't catch this.

Comment 3

[Brendan Eich [:brendan]]

Comment on attachment 378132 [details] [diff] [review]
fix

So JO and Str are from ES5 draft, but life's simpler there it seems.

>+static JSBool CallReplacerFunction(JSContext *cx, jsid id, JSObject *holder,
>+                                   StringifyContext *scx, jsval *vp);
>+static JSBool Str(JSContext *cx, jsid id, JSObject *holder,
>+                  StringifyContext *scx, jsval *vp, bool callReplacer=true);

Space on both sides of = in house style.

r=me with that, thanks.

/be

Comment 4

[Robert Sayre]

(In reply to comment #3)
> (From update of attachment 378132 [details] [diff] [review])
> So JO and Str are from ES5 draft, but life's simpler there it seems.

The spec is written as if implemented in JS. Everything buffers output, rather than streaming when ready.

Comment 5

[Robert Sayre]

pushed with correct spacing
http://hg.mozilla.org/tracemonkey/rev/29ed571daf38

Comment 6

[Robert Sayre]

http://hg.mozilla.org/mozilla-central/rev/29ed571daf38

Comment 7

[Robert Sayre]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/907d36c4ea91