493732 - Section expander and collapser in about:certerror appear on the left side and have the wrong direction in RTL mode

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[(no longer active)]

Attachment: Patch (v1)

Section expander and collapser in about:certerror appear on the left side and have the wrong direction in RTL mode

Comment 1

[Dão Gottwald [:dao]]

Comment on attachment 378320 [details] [diff] [review]
Patch (v1)

>+body[dir="rtl"] #technicalContent[collapsed] > h2,
>+body[dir="rtl"] #expertContent[collapsed] > h2{

nit: insert a space before {.

>-  skin/classic/browser/section_collapsed.png
>+  skin/classic/browser/section_collaped.png
>+  skin/classic/browser/section_collaped-rtl.png

Looks like a fatal typo... Have you tested this?

Comment 2

[(no longer active)]

Attachment: Patch (v2)

(In reply to comment #1)
> (From update of attachment 378320 [details] [diff] [review])
> >+body[dir="rtl"] #technicalContent[collapsed] > h2,
> >+body[dir="rtl"] #expertContent[collapsed] > h2{
> 
> nit: insert a space before {.

Fixed.

> >-  skin/classic/browser/section_collapsed.png
> >+  skin/classic/browser/section_collaped.png
> >+  skin/classic/browser/section_collaped-rtl.png
> 
> Looks like a fatal typo... Have you tested this?

Tested it with compiling on Windows, and with manual patching of files in chrome directory on Linux, which bit me here... :-(

Comment 3

[(no longer active)]

johnath: ping?

Comment 4

[Johnathan Nightingale [:johnath]]

Comment on attachment 378325 [details] [diff] [review]
Patch (v2)

This looks fine to me, but you don't actually need my review if you already have dao's - clearing the (very old! Sorry!) request.

Comment 5

[(no longer active)]

Attachment: For check-in

This patch is ready to be |hg import|ed and landed.  Please note that this patch is adding some files...

Comment 6

[[e-mail]]

Comment on attachment 468483 [details] [diff] [review]
For check-in

http://hg.mozilla.org/mozilla-central/rev/a59221f025aa