493739 - performance runtests.py should support winmo emulator

Status: RESOLVED WONTFIX

(Tamarin Graveyard :: Tools, defect, P4)

Description

[Dan Schaffer]

the performance runtests.py should run easily with the emulator using the same mechanism as the acceptance tests

Comment 1

[Dan Schaffer]

Attachment: patch

also edit test/performance/dir.asc_args set CONFIG:desktop=false

will use Date() object instead of getTimer().  on winmo getTimer() only has second resolution so results will get rounded off.  after setting the flag delete performance .abc to rebuild test tests.

Comment 2

[Steven Johnson]

Comment on attachment 378340 [details] [diff] [review]
patch

patch doesn't contain the edits to asc_args or to use new Date()... hopefully those won't have to be done as local-only changes every time? (ie isn't there a way to make existing code work as-is?)

Comment 3

[Brent Baker]

Comment on attachment 378340 [details] [diff] [review]
patch

If you change performance/dir.asc_args to set the CONFIG::desktop to false, it will use smaller datasets and also use getTimer() instead of Date() which gives millisecond resolution in the tests.

Comment 4

[Dan Schaffer]

verified patch still works and pushed in 2850:d14d124e85f5

Comment 5

[Dan Schaffer]

marking bug fixed and closing.

Comment 6

[Brent Baker]

Comment on attachment 378340 [details] [diff] [review]
patch

reopening bug because I just reverted the change. This change is not correct.

1) why is the config set to a string that does not match the performance configs? Performance configs are not like acceptance config strings
2) disabling the call to determine OS and version if config is set is incorrect. The needs to be known for logging and the version also needs to be known for logging purposes

This patch was reverted in changeset 2952:8d95dfcd273e because it is causing the logging of performance data to fail (unknown OS and unknown version number)

Comment 7

[Trevor Baker]

Winmo 6.5 not supported.  New issue could be logged if similar issue exists when WinPhone 7 is supported.