performance runtests.py should support winmo emulator

RESOLVED WONTFIX

Status

Tamarin
Tools
P4
normal
RESOLVED WONTFIX
9 years ago
7 years ago

People

(Reporter: Dan Schaffer, Assigned: Dan Schaffer)

Tracking

(Blocks: 1 bug)

unspecified
Q3 11 - Serrano
x86
Windows XP
Bug Flags:
flashplayer-triage +

Details

Attachments

(1 attachment)

1.15 KB, patch
Steven Johnson
: review+
Brent Baker
: review-
Details | Diff | Splinter Review
(Assignee)

Description

9 years ago
the performance runtests.py should run easily with the emulator using the same mechanism as the acceptance tests
Flags: flashplayer-triage+
(Assignee)

Comment 1

9 years ago
Created attachment 378340 [details] [diff] [review]
patch

also edit test/performance/dir.asc_args set CONFIG:desktop=false

will use Date() object instead of getTimer().  on winmo getTimer() only has second resolution so results will get rounded off.  after setting the flag delete performance .abc to rebuild test tests.
Assignee: nobody → dschaffe
Status: NEW → ASSIGNED
Attachment #378340 - Flags: review?(stejohns)
(Assignee)

Updated

9 years ago
Attachment #378340 - Flags: review?(brbaker)

Comment 2

9 years ago
Comment on attachment 378340 [details] [diff] [review]
patch

patch doesn't contain the edits to asc_args or to use new Date()... hopefully those won't have to be done as local-only changes every time? (ie isn't there a way to make existing code work as-is?)
Attachment #378340 - Flags: review?(stejohns) → review+

Comment 3

9 years ago
Comment on attachment 378340 [details] [diff] [review]
patch

If you change performance/dir.asc_args to set the CONFIG::desktop to false, it will use smaller datasets and also use getTimer() instead of Date() which gives millisecond resolution in the tests.
Attachment #378340 - Flags: review?(brbaker) → review+

Updated

9 years ago
Priority: -- → P3
Target Milestone: --- → flash10.1

Updated

9 years ago
Priority: P3 → P4
(Assignee)

Comment 4

9 years ago
verified patch still works and pushed in 2850:d14d124e85f5
(Assignee)

Comment 5

9 years ago
marking bug fixed and closing.
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
(Assignee)

Updated

9 years ago
Status: RESOLVED → VERIFIED

Comment 6

8 years ago
Comment on attachment 378340 [details] [diff] [review]
patch

reopening bug because I just reverted the change. This change is not correct.

1) why is the config set to a string that does not match the performance configs? Performance configs are not like acceptance config strings
2) disabling the call to determine OS and version if config is set is incorrect. The needs to be known for logging and the version also needs to be known for logging purposes

This patch was reverted in changeset 2952:8d95dfcd273e because it is causing the logging of performance data to fail (unknown OS and unknown version number)
Attachment #378340 - Flags: review+ → review-

Updated

8 years ago
Status: VERIFIED → REOPENED
Resolution: FIXED → ---

Updated

8 years ago
Target Milestone: flash10.1 → flash10.2

Updated

7 years ago
Blocks: 607714

Comment 7

7 years ago
Winmo 6.5 not supported.  New issue could be logged if similar issue exists when WinPhone 7 is supported.
Status: REOPENED → RESOLVED
Last Resolved: 9 years ago7 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.