Closed Bug 493760 Opened 15 years ago Closed 15 years ago

Assertion failure: cg->stackDepth >= 0, js1_8_1/regress/regress-452498-074.js, js1_8_1/regress/regress-452498-077.js

Categories

(Core :: JavaScript Engine, defect, P1)

Product:
Core
Component:
JavaScript Engine
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla1.9.1

People

(Reporter: bc, Assigned: brendan)

References

Details

(4 keywords, Whiteboard: fixed-in-tracemonkey)

Attachments

(1 file, 1 obsolete file)

fixed fix
578 bytes, patch
mrbkap
: review+
Details | Diff | Splinter Review 
js1_8_1/regress/regress-452498-074.js, js1_8_1/regress/regress-452498-077.js

Assertion failure: cg->stackDepth >= 0, at ../jsemit.cpp:184

http://hg.mozilla.org/tracemonkey/rev/aac8141341bf
Flags: in-testsuite+
Flags: blocking1.9.1?
Summary: Assertion failure: cg->stackDepth >= 0, js1_8_1/regress/regress-452498-074.js, js1_8_1/regress/regress-452498-077.js → Assertion failure: cg->stackDepth >= 0, js1_8_1/regress/regress-452498-074.js, js1_8_1/regress/regress-452498-077.js
Argh, I ran the testsuite. I bet those tests fail but do not assert without the patch for bug 493466 -- true? That would explain how I missed it: I use comm -3 to compare failures.txt files, but I should look more closely.

This should be against trunk, or really against the tracemonkey repo, not against the 1.9.1 branch, too (please correct me if I'm mistaken), since the patch for bug 493466 has not made it out of tracemonkey yet.

/be
Assignee: general → brendan
Status: NEW → ASSIGNED
OS: Mac OS X → All
Priority: -- → P1
Hardware: x86 → All
Version: 1.9.1 Branch → Trunk
Oops, sayrer updated mozilla-central too. So "Trunk" is good for this bug's Version field, but no 1.9.1 worries, eh?

/be
Target Milestone: --- → mozilla1.9.1
Argh^2, I must have mismanaged my "good" results.txt file. Bob has the regressing bug dead to rights. Sorry.

/be
(In reply to comment #2)
> Oops, sayrer updated mozilla-central too. So "Trunk" is good for this bug's
> Version field, but no 1.9.1 worries, eh?

Right.
Flags: blocking1.9.1? → blocking1.9.1+
This should indeed block, it's an embarrassing typo in the patch for bug 493466. The two bugs' patches should be taken together.

/be
Attached patch fix (obsolete) — — Splinter Review 

        Attachment #378398 -
        Flags: review?(mrbkap)

    
    

    
  
All hail the testsuite for finding this.

http://hg.mozilla.org/tracemonkey/rev/58f47d8d80ec

/be
Whiteboard: fixed-in-tracemonkey

    
    

    
  
Hail Bob, I mean -- the testsuite isn't a person, although it has personality and I am growing fond of it. :-P

http://hg.mozilla.org/mozilla-central/rev/a27e28295c72

/be
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED

    
    

    
  
Comment on attachment 378398 [details] [diff] [review]
fix

Sorry for missing this in review :-/.

        Attachment #378398 -
        Flags: review?(mrbkap) → review+

    
    

    
  
Backed out of mozilla-central due to chrome mochitest failures:

http://hg.mozilla.org/mozilla-central/rev/27bda06a2e7d

/be
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

    
  
Status: REOPENED → ASSIGNED

    
    

    
  
Backed out of tm too:

http://hg.mozilla.org/tracemonkey/rev/b3391d850e34

/be
Whiteboard: fixed-in-tracemonkey

    
    

    
  

      
      
      
      

        Attached patch
          
          
        fixed fix
        — 
          — Splinter Review
      

    


  
Thanks a ton to sayrer for test buddying.

/be

        Attachment #378398 -
        Attachment is obsolete: true

        Attachment #378491 -
        Flags: review?(mrbkap)

        Attachment #378491 -
        Flags: review?(mrbkap) → review+

    
    

    
  
Passes chrome mochitests.

/be

    
    

    
  
Fixed in tm:

http://hg.mozilla.org/tracemonkey/rev/241dad2cc2e3

Will wait for green before hitting m-c.

/be
Whiteboard: fixed-in-tracemonkey

    
    

    
  
http://hg.mozilla.org/mozilla-central/rev/241dad2cc2e3
Status: ASSIGNED → RESOLVED
Closed: 15 years ago → 15 years ago
Resolution: --- → FIXED

    
    

    
  
This *may* have caused bug 494143, now a blocker.

    
  
Blocks: 494143

    
    

    
  
Not may, it is guilty for it.

    
    

    
  
regressions block regressors.
No longer blocks: 494143
Depends on: 494143

    
  
Depends on: 494544

    
    

    
  
v 1.9.1, 1.9.2
Status: RESOLVED → VERIFIED
Keywords: fixed1.9.1 → verified1.9.1

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: