493812 - Some css file have selectors related to classes\rules that don't exist anymore

Status: RESOLVED FIXED

(Calendar :: Calendar Views, defect)

Description

[Decathlon]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; it-IT; rv:1.9.0.10) Gecko/2009042316 Firefox/3.0.10
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; it; rv:1.9.1b5pre) Gecko/20090518 Lightning/1.0pre Shredder/3.0b3pre

Patch attachment 351864 [details] [diff] [review], that fixed bug 447683, deleted binding "calendar-month-view-column-header" and some xul elements with CSS classes in calendar-month-view.xml file, but in calendar-views.css and calendar-view-bindings.css files there still are selectors that refer to those elements.
I have found at least three elements:
calendar-month-view-column-header
(http://hg.mozilla.org/comm-central/rev/fe713242a103#l4.7)

calendar-month-view-column-header-container
(http://hg.mozilla.org/comm-central/rev/fe713242a103#l4.9)

calendar-month-view-column-header-label
(http://hg.mozilla.org/comm-central/rev/fe713242a103#l4.10)

Reproducible: Always

Steps to Reproduce:
1. search three classes mentioned above on Comm-Central repository or on
http://mxr.mozilla.org/comm-central/source/calendar/
Actual Results:  
you will get only links to css files and no link to xml\xul files.

Expected Results:  
every selector should refer to a binding\class\ID\... defined inside a xul\xml file.

Comment 1

[Martin Schröder [:martinschroeder]]

Confirming... first step to clean up our CSS files. I suspect there is more obsolete CSS lying around.

Comment 2

[Decathlon]

Attachment: fix for the issue in comment #0

If mentioned selectors in comment #0 can be deleted with any other considerations, this patch should be right.

Comment 3

[Martin Schröder [:martinschroeder]]

Comment on attachment 379242 [details] [diff] [review]
fix for the issue in comment #0

Removing these selectors should be fine! r=mschroeder

Comment 4

[Mark Banner (:standard8) (afk until 13 Aug)]

Checked in: http://hg.mozilla.org/comm-central/rev/1155c1c0ed0d

Comment 5

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

These bugs are likely targeted at Lightning 1.0b1, not Lightning 1.0. If this change was done in error, please adjust the target milestone to its correct value. To filter on this bugspam, you can use "lightning-10-target-move".