If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Some css file have selectors related to classes\rules that don't exist anymore

RESOLVED FIXED in 1.0b1

Status

Calendar
Calendar Views
--
trivial
RESOLVED FIXED
9 years ago
6 years ago

People

(Reporter: Decathlon, Assigned: Decathlon)

Tracking

unspecified
1.0b1

Details

Attachments

(1 attachment)

(Assignee)

Description

9 years ago
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; it-IT; rv:1.9.0.10) Gecko/2009042316 Firefox/3.0.10
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; it; rv:1.9.1b5pre) Gecko/20090518 Lightning/1.0pre Shredder/3.0b3pre

Patch attachment 351864 [details] [diff] [review], that fixed bug 447683, deleted binding "calendar-month-view-column-header" and some xul elements with CSS classes in calendar-month-view.xml file, but in calendar-views.css and calendar-view-bindings.css files there still are selectors that refer to those elements.
I have found at least three elements:
calendar-month-view-column-header
(http://hg.mozilla.org/comm-central/rev/fe713242a103#l4.7)

calendar-month-view-column-header-container
(http://hg.mozilla.org/comm-central/rev/fe713242a103#l4.9)

calendar-month-view-column-header-label
(http://hg.mozilla.org/comm-central/rev/fe713242a103#l4.10)

Reproducible: Always

Steps to Reproduce:
1. search three classes mentioned above on Comm-Central repository or on
http://mxr.mozilla.org/comm-central/source/calendar/
Actual Results:  
you will get only links to css files and no link to xml\xul files.

Expected Results:  
every selector should refer to a binding\class\ID\... defined inside a xul\xml file.
Confirming... first step to clean up our CSS files. I suspect there is more obsolete CSS lying around.
Severity: minor → trivial
Status: UNCONFIRMED → NEW
Component: General → Calendar Views
Ever confirmed: true
QA Contact: general → views
(Assignee)

Comment 2

8 years ago
Created attachment 379242 [details] [diff] [review]
fix for the issue in comment #0

If mentioned selectors in comment #0 can be deleted with any other considerations, this patch should be right.
Attachment #379242 - Flags: review?(mschroeder)
Assignee: nobody → bv1578
Status: NEW → ASSIGNED
Comment on attachment 379242 [details] [diff] [review]
fix for the issue in comment #0

Removing these selectors should be fine! r=mschroeder
Attachment #379242 - Flags: review?(mschroeder) → review+
Keywords: checkin-needed
Checked in: http://hg.mozilla.org/comm-central/rev/1155c1c0ed0d
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 1.0
These bugs are likely targeted at Lightning 1.0b1, not Lightning 1.0. If this change was done in error, please adjust the target milestone to its correct value. To filter on this bugspam, you can use "lightning-10-target-move".
Target Milestone: 1.0 → 1.0b1
You need to log in before you can comment on or make changes to this bug.