Closed
Bug 493823
Opened 15 years ago
Closed 15 years ago
One test from browser_394759 not being run
Categories
(Firefox :: Session Restore, defect)
Firefox
Session Restore
Tracking
()
VERIFIED
FIXED
Firefox 3.6a1
Tracking | Status | |
---|---|---|
status1.9.1 | --- | .3-fixed |
People
(Reporter: zpao, Assigned: zpao)
References
Details
(Keywords: verified1.9.1)
Attachments
(1 file, 1 obsolete file)
3.80 KB,
patch
|
samuel.sidler+old
:
approval1.9.1.3+
|
Details | Diff | Splinter Review |
Debugging bug 490040 made me find a test that wasn't being hit. It's a simple fix & merely oversight on my part.
Assignee | ||
Comment 1•15 years ago
|
||
Ah, now with the fix applied, it's hitting code that wasn't being hit before & we're getting a JS error, so it looks like the fix will be slightly more than just making sure we run the test.
Assignee | ||
Comment 2•15 years ago
|
||
The "error" in comment #1 was actually just a warning (about window.isPopup not existing). Simple fix is to force it to a boolean like I did. Not _necessary_ but better to not have warnings. The now running test passes on both OS X & Windows, so should be fine.
Attachment #378437 -
Flags: review?(zeniko)
Updated•15 years ago
|
Attachment #378437 -
Flags: review?(zeniko) → review+
Assignee | ||
Comment 3•15 years ago
|
||
Updated so it will cleanly apply (just changes in context).
Attachment #378437 -
Attachment is obsolete: true
Assignee | ||
Updated•15 years ago
|
Keywords: checkin-needed
Whiteboard: [needs 1.9.1 landing]
Assignee | ||
Comment 5•15 years ago
|
||
(In reply to comment #4) > Needs 1.9.2 landing before 1.9.1. (no?) Yea, probably best to wait until we're past this whole release thing anyway.
Comment 6•15 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/ffe39a4c414a
Updated•15 years ago
|
Target Milestone: --- → Firefox 3.6a1
Assignee | ||
Comment 7•15 years ago
|
||
Comment on attachment 383303 [details] [diff] [review] Patch v0.2 (for check-in) This should probably get into branch at some point
Attachment #383303 -
Flags: approval1.9.1.2?
Updated•15 years ago
|
Attachment #383303 -
Flags: approval1.9.1.2? → approval1.9.1.3?
Comment 8•15 years ago
|
||
Comment on attachment 383303 [details] [diff] [review] Patch v0.2 (for check-in) Approved for 1.9.1.3. a=ss
Attachment #383303 -
Flags: approval1.9.1.3? → approval1.9.1.3+
Comment 9•15 years ago
|
||
Pushed http://hg.mozilla.org/releases/mozilla-1.9.1/rev/3c1154888ac7
status1.9.1:
--- → .3-fixed
Comment 10•15 years ago
|
||
Verified fixed on trunk and 1.9.1 based on no orangeness within the last 11 days.
Status: RESOLVED → VERIFIED
Keywords: verified1.9.1
You need to log in
before you can comment on or make changes to this bug.
Description
•