build error due to mislocated cairo headers

RESOLVED FIXED in mozilla1.9.2a1

Status

Firefox Build System
General
RESOLVED FIXED
9 years ago
5 months ago

People

(Reporter: Peter Weilbacher, Assigned: Peter Weilbacher)

Tracking

Trunk
mozilla1.9.2a1
x86
OS/2

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

fix
2.41 KB, patch
Benjamin Smedberg
: review+
Details | Diff | Splinter Review
(Assignee)

Description

9 years ago
In today's build from mozilla-central some cairo headers end up in dist/include/cairo/ and some in dist/include which leads to an error when building widget/src/os2/ where cairo.h as included by cairo-os2.h cannot be found.

It seems to me that the EXPORTS headers in gfx/cairo/cairo/src/Makefile.in all have to be marked EXPORTS_cairo instead. What I don't understand is how other platforms could live without this for the past day...
(Assignee)

Comment 1

9 years ago
Created attachment 378438 [details] [diff] [review]
fix

Doh! dist/include is always found, so to fix the build break on OS/2 I just needed to add the cairo-flags in widget/src/os2/. But still, I guess it was meant that all cairo headers end up in dist/include/cairo/ as in this patch.
Assignee: nobody → mozilla
Status: NEW → ASSIGNED
Attachment #378438 - Flags: review?(benjamin)

Updated

9 years ago
Attachment #378438 - Flags: review?(benjamin) → review+
(Assignee)

Comment 2

9 years ago
http://hg.mozilla.org/mozilla-central/rev/2c7f20f05bd6
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Flags: in-testsuite-
Target Milestone: --- → mozilla1.9.2a1
Version: unspecified → Trunk

Updated

5 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.