Closed Bug 493834 Opened 15 years ago Closed 15 years ago

build error due to mislocated cairo headers

Categories

(Firefox Build System :: General, defect)

x86
OS/2
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.9.2a1

People

(Reporter: mozilla, Assigned: mozilla)

References

Details

Attachments

(1 file)

In today's build from mozilla-central some cairo headers end up in dist/include/cairo/ and some in dist/include which leads to an error when building widget/src/os2/ where cairo.h as included by cairo-os2.h cannot be found.

It seems to me that the EXPORTS headers in gfx/cairo/cairo/src/Makefile.in all have to be marked EXPORTS_cairo instead. What I don't understand is how other platforms could live without this for the past day...
Attached patch fixSplinter Review
Doh! dist/include is always found, so to fix the build break on OS/2 I just needed to add the cairo-flags in widget/src/os2/. But still, I guess it was meant that all cairo headers end up in dist/include/cairo/ as in this patch.
Assignee: nobody → mozilla
Status: NEW → ASSIGNED
Attachment #378438 - Flags: review?(benjamin)
Attachment #378438 - Flags: review?(benjamin) → review+
http://hg.mozilla.org/mozilla-central/rev/2c7f20f05bd6
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Flags: in-testsuite-
Target Milestone: --- → mozilla1.9.2a1
Version: unspecified → Trunk
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: