493837 - JarMaker fails when using ../configure directly

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Andreas Gal :gal]

The test_jar_mn test in the xpcshell tests fails if configure is used directly to create a build directory.

Steps to reproduce:

make a directory "debug-build" in srcdir and then use ../configure. Run make and then make check.

I understand this is not the recommended way of running tests, but this is the only test that fails and its really super annoying. I would greatly appreciate if someone could fix this.

Comparing manifests...
Comparing packages...
diff: ../../../dist/xpi-stage/test_jar_mn/chrome/test/three/l10nfile.txt: No such file or directory
diff: ../../../dist/xpi-stage/test_jar_mn/chrome/test/two/otherfile.xml: No such file or directory
TEST-UNEXPECTED-FAIL | config/tests/ref-simple | different content in jar
make[2]: *** [check-symlink] Error 1
make[1]: *** [check-jar-mn] Error 2
make: *** [check] Error 2

Comment 1

[Andreas Gal :gal]

This is really more a test/build issue, but I don't know what component to use here.

Comment 2

[(not currently active) Ted Mielczarek]

Pike wrote these tests.

Comment 3

[Axel Hecht [:Pike]]

The problem is that the symlink for dist/xpi-stage/test_jar_mn/chrome/test/two/otherfile.xml ends up being relative to config/tests/src-simple instead of relative to the directory the link is in.

Comment 5

[Andreas Gal :gal]

This bug is really annoying. Could we please disable the test until its fixed?

Comment 6

[Robert Sayre]

no. use a mozconfig (... :)

Comment 7

[Andreas Gal :gal]

I doubt I am the only person who prefers direct configure over some obscure custom mozconfig thing. Think of the users =)

Comment 8

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

(In reply to comment #3)
> The problem is that the symlink for
> dist/xpi-stage/test_jar_mn/chrome/test/two/otherfile.xml ends up being relative
> to config/tests/src-simple instead of relative to the directory the link is in.

So what's the fix?

Comment 9

[Axel Hecht [:Pike]]

So, the failing tests actually indicate a real failure of JarMaker for symlinks with relative srcdir.

The fix depends a bit on what we actually want it to do.

The easiest way to fix it is to make all symlinks point to absolute paths to the sourcedir. Not sure if it's vital to be able to move the parent of both src and obj dir and have the links still work.

Comment 10

[Axel Hecht [:Pike]]

Ted said on irc that he doesn't really care if we use relative or absolute links, and I can see them failing unexpectedly in both ways (either move the build dir, or the parent of both build and src), thus I'm going for the easier solution.

Comment 11

[Axel Hecht [:Pike]]

Attachment: convert the various source dirs to absolute paths

Using absolute paths for the various breeds of source dirs. That fixes the tests, and doesn't regress the regular jar build, which I tested on mac.

Comment 12

[Axel Hecht [:Pike]]

http://hg.mozilla.org/mozilla-central/rev/31c75e871924, FIXED.

This is a low-risk symlink only fix that we should take on the branch, too, IMHO.

Nothing 3.5.0, but IMHO definitely wanted.

Comment 13

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 380160 [details] [diff] [review]
convert the various source dirs to absolute paths

Removing dead flag; if you want it, please use one of the current flags.

Comment 14

[Axel Hecht [:Pike]]

I still think we should take this on the branch. This will make further patches to JarMaker.py like in bug 505713 easier to take on the stable branch, and help us help localizers to start new locales on that branch.

Comment 15

[Samuel Sidler (old account; do not CC)]

Do we expect many localizers will start on that branch given our anticipated ship dates for 3.6 and 3.7?

Comment 16

[Axel Hecht [:Pike]]

We do have active new projects, so yes.

Comment 17

[Samuel Sidler (old account; do not CC)]

Not blocking, but wanted. Does this patch apply to 1.9.1?

Comment 18

[Axel Hecht [:Pike]]

Yes, applies fine.

Comment 19

[Samuel Sidler (old account; do not CC)]

Comment on attachment 380160 [details] [diff] [review]
convert the various source dirs to absolute paths

Approved for 1.9.1.2. a=ss for release-drivers

Please land on mozilla-1.9.1 and use the ".2-fixed" option of the "status1.9.1" flag.

Comment 20

[Axel Hecht [:Pike]]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/957cf306a223, fixed1.9.1.2

Comment 21

[u279076]

Using the latest mozilla-1.9.1 (pulled an hour ago), I cannot reproduce this bug.  Verified1.9.1