Closed
Bug 493866
Opened 15 years ago
Closed 15 years ago
NanoJIT relies on undefined C behavior; causes crash
Categories
(Tamarin Graveyard :: Baseline JIT (CodegenLIR), defect)
Tracking
(Not tracked)
VERIFIED
FIXED
flash10.1
People
(Reporter: mmelanso, Unassigned)
References
Details
Attachments
(1 file)
|
582 bytes,
patch
|
edwsmith
:
review+
|
Details | Diff | Splinter Review |
The NanoJIT contains a line that relies on undefined C behavior. gcc compiles the code in a way contrary to assumption. Attached patch fixes it.
|
||
Comment 1•15 years ago
|
||
Hey Mike, thanks for the patch -- you should ask someone to review it (all patches must be reviewed before landing). If you're unsure who the best reviewer is, assign it to me (stejohns@adobe.com) and I'll delegate it to the proper reviewer.
|
||
Updated•15 years ago
|
Attachment #378465 -
Flags: review?(edwsmith)
|
|
||
Comment 2•15 years ago
|
||
Comment on attachment 378465 [details] [diff] [review] Fix a crash in the x86_64 nanaJIT Edwin, looks like an obvious bug / obviously correct fix.
|
||
Updated•15 years ago
|
Attachment #378465 -
Flags: review?(edwsmith) → review+
|
|
||
Comment 3•15 years ago
|
||
i'll push once builds stabilize
|
|
||
Comment 4•15 years ago
|
||
Ed, time to push this.
|
|
||
Comment 5•15 years ago
|
||
pushed http://hg.mozilla.org/tamarin-redux/rev/fc1740d5148a
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
|
||
Comment 6•15 years ago
|
||
Resolved fixed engineering / work item that has been pushed. Setting status to verified.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•