NanoJIT relies on undefined C behavior; causes crash

VERIFIED FIXED in flash10.1

Status

--
critical
VERIFIED FIXED
10 years ago
9 years ago

People

(Reporter: mmelanso, Unassigned)

Tracking

unspecified
flash10.1
x86_64
Linux

Details

Attachments

(1 attachment)

(Reporter)

Description

10 years ago
Created attachment 378465 [details] [diff] [review]
Fix a crash in the x86_64 nanaJIT

The NanoJIT contains a line that relies on undefined C behavior. gcc compiles the code in a way contrary to assumption. Attached patch fixes it.

Comment 1

10 years ago
Hey Mike, thanks for the patch -- you should ask someone to review it (all patches must be reviewed before landing). If you're unsure who the best reviewer is, assign it to me (stejohns@adobe.com) and I'll delegate it to the proper reviewer.

Updated

10 years ago
Attachment #378465 - Flags: review?(edwsmith)

Comment 2

10 years ago
Comment on attachment 378465 [details] [diff] [review]
Fix a crash in the x86_64 nanaJIT

Edwin, looks like an obvious bug / obviously correct fix.

Updated

10 years ago
Blocks: 486742

Updated

10 years ago
Attachment #378465 - Flags: review?(edwsmith) → review+

Comment 3

10 years ago
i'll push once builds stabilize

Comment 4

9 years ago
Ed, time to push this.

Comment 5

9 years ago
pushed
http://hg.mozilla.org/tamarin-redux/rev/fc1740d5148a
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED

Comment 6

9 years ago
Resolved fixed engineering / work item that has been pushed.  Setting status to verified.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.