If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

video control playback postion bar disconnects from thumb while dragging

RESOLVED FIXED in mozilla1.9.2a1



Video/Audio Controls
9 years ago
8 years ago


(Reporter: Dolske, Assigned: Dolske)




Firefox Tracking Flags

(Not tracked)



(1 attachment, 1 obsolete attachment)

4.15 KB, patch
: review+
: approval1.9.1+
Details | Diff | Splinter Review


9 years ago
Created attachment 378493 [details] [diff] [review]
Patch v.1

The video control scrubber bar is composed of 3 pieces -- a static background bar, a bar that shows the amount of data buffered, and playback position bar. The last of these is just for visual style, basically to make the scrubber bar to the left of the thumb a different color than the bar to the right.

It's currently updated after a timeupdate event, which isn't really right. For example, while dragging the thumb rapidly the bar will lag behind the thumb's position, and looks disconnected and broken.

Updating it from the valueChange callback (when the <scale>'s value changed) fixes this.
Attachment #378493 - Flags: review?(neil)

Comment 1

9 years ago
Created attachment 378694 [details] [diff] [review]
Patch v.2

The updated patch for bug 493523 removes the need for the last chunk of the v.1 patch.
Attachment #378493 - Attachment is obsolete: true
Attachment #378694 - Flags: review?(neil)
Attachment #378493 - Flags: review?(neil)

Comment 2

9 years ago
We could really do with extra spacers on each side of the thumb that we then
style separately... that might also allow themes to do :active sliders ;-)

Comment 3

9 years ago
Comment on attachment 378694 [details] [diff] [review]
Patch v.2

r=me by code inspection.

>+                if (this.type == "scrubber") {
>+                    // Update the value bar to match the thumb position.
>+                    var percent = this.value / newValue;
>+                    this.valueBar.value = Math.round(percent * 10000); // has max=10000
>+                }
Not sure whether it helps to do this outside the switch.
Attachment #378694 - Flags: review?(neil) → review+
Comment on attachment 378694 [details] [diff] [review]
Patch v.2


Won't hold release for this, but should be super-safe. Make sure it bakes for a cycle on mozilla-central before you move it to 1.9.1

This is the only one of your recent batch that makes me really nervous.
Attachment #378694 - Flags: approval1.9.1+

Comment 5

8 years ago
Pushed http://hg.mozilla.org/mozilla-central/rev/f645386cbf36
Last Resolved: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1

Comment 6

8 years ago
Pushed to 191: http://hg.mozilla.org/releases/mozilla-1.9.1/rev/4ebcbc3dae4d
Keywords: fixed1.9.1


8 years ago
Component: Video/Audio → Video/Audio Controls
Product: Core → Toolkit
QA Contact: video.audio → video.audio
Version: Trunk → unspecified
You need to log in before you can comment on or make changes to this bug.