493941 - Can't temporarily modify column list for a saved search

Status: NEW

(Bugzilla :: Query/Bug List, defect)

Description

[Kent Rogers [:mrbball]]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.0.10) Gecko/2009042315 Firefox/3.0.10
Build Identifier: 3.2.3

A slight variation on bug 448690:

- Run a saved search
- Click on "Change Columns" link
- Check a new column that was not part of the saved search's custom column list
- Uncheck "Save this column list only for search ..."
- Click the "Change Columns" button

I would have expected the above set of steps to display the saved search,
with the newly selected column included, but without the newly selected
column being remembered in the saved search's custom column list.  Does
that make sense?

That is not what happens, though.  After clicking the "Change Columns"
button on colchange.cgi form, the saved query displays the same as it
ever did, apparently completely ignoring my request to add another
column to the display.

I can see that what actually happens is that the "Change Columns" action
is applied to the default column list (and not the saved search's custom
column list), but that is certainly not intuitive and not what I wanted.

My intent was to run my saved search and 'temporarily' add a column or
two (i.e. without altering the custom columns that are saved with the
search and without altering the default column list), but there does not
appear to be any way to do that.

I'm not familiar with this area of the code, but would it be possible to
have two checkboxes on the colchange form in this case:

  - Save this column list for the default search
  - Save this column list only for search ...

Then in the absence of check marks in either of these two checkboxes,
the changes to the column list would only be temporary (i.e. only apply
to the current query)?

Reproducible: Always

Comment 1

[Max Kanat-Alexander]

I'd consider this a bug.

Comment 2

[Teemu Mannermaa (:wicked)]

Bug part of this is handled in the bug 448690. After that's fixed the "slight variation" STR should be fixed.

I asked Kent to open this as an enh in bug 448690 comment 6 to add a checkbox on colchange.cgi to save column list as a default in addition to save it in the saved search. If both are unchecked, nothing is saved permanently but rather the current search is run with the "temporar" columns. If the search is saved (from the buglist) then the "temporar" column list is saved in the saved search.

We could even remove the "save this column list in the saved search" checkbox from colchange and allow user to save it using the buglist only. This way the work flow of changing columns would be same as when editing the search itself (via Edit Search).

Comment 3

[Frédéric Buclin]

We no longer accept new features for Bugzilla 3.6. Retargetting to 3.8.

Comment 4

[Frédéric Buclin]

We are going to branch for Bugzilla 4.4 next week and this bug is either too invasive to be accepted for 4.4 at this point or shows no recent activity. The target milestone is reset and will be set again *only* when a patch is attached and approved.

I ask the assignee to reassign the bug to the default assignee if you don't plan to work on this bug in the near future, to make it clearer which bugs should be fixed by someone else.