Closed Bug 493973 Opened 15 years ago Closed 7 years ago

performance: Investigate moving the context and edit menu into a lazily-loaded overlay

Categories

(Firefox :: Menus, defect, P2)

defect

Tracking

()

RESOLVED WONTFIX

People

(Reporter: asaf, Assigned: asaf)

References

(Blocks 1 open bug)

Details

(Keywords: perf, Whiteboard: [ts][txul])

In the previous release cycle, there was an attempt to optimize TP by hiding the edit menu's items and shutting their command-update mechanism. That didn't work, but the complex-code is still in place (I tend to complexity of this code is the main reason that it didn't help perf after all)

Experience shows that popups (or maybe just "heavy" poupup) may have notable affect on Txul - the startUI-poupp regressed Txul much when it landed. In that case, we fixed the regression by loading editBookmarkOverlay lazily, meaning that the overlay is applied the first time it's needed. This report is on applying this optimization on the edit menu along with the browser's context menu, and on removing the old edit-menu optimization that's mentioned above.

While working this, I noticed that various attributes are set on edit/context-menu items unnecessarily. I'll fix that too
Whiteboard: [eta
Whiteboard: [eta → [eta 7/8]
Whiteboard: [eta 7/8] → [ts][txul
Whiteboard: [ts][txul → [ts][txul]
OS: Mac OS X → All
Hardware: x86 → All
Target Milestone: Firefox 3.6a1 → ---
Priority: -- → P2
Blocks: 447581
If these panels are display: none, I don't think they incur a significant startup cost, and I don't think lazy loaded XUL overlays would be considered a good idea now, given that some people would like to remove support for xul overlays completely.
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.